open-build-service
open-build-service copied to clipboard
openSUSE
Add withfilelist parameter to the binary query
This should avoid unnecessarily querying filelist if not required by the user.
To test this, compare the output of these two endpoints on a built package file
/build/$project/$repository/$arch/$package/$filename?view=fileinfo_ext
/build/$project/$repository/$arch/$package/$filename?view=fileinfo_ext&withfilelist
The code is touching the backend. Could any of the developers of the @openSUSE/obs-backend developers leave a review, please? Thanks.
except that you missed the [backend] prefix it should be fine.
But are you aware that there are rpms with more then 100k files inside? the current web interface would not be able to handle it nicely IMHO. Try kernel-source for example.
there are rpms with more then 100k files inside? the current web interface would not be able to handle it
We could use jQuery datatables for this. So the page loads, the data is fetched through an AJAX query. The table has pagination, search and sorting (maybe more, I don't remember now on top of my head).
Tables aren't that great at displaying trees tbh, I would love this to be a widget that can display the information in a structured way instead
Tables aren't that great at displaying trees tbh, I would love this to be a widget that can display the information in a structured way instead
We can start with the tables and improve later...
You should be able to use withfilelist parameter in the api, frontend doesn't currently have any way to use it though
You should be able to use withfilelist parameter in the api, frontend doesn't currently have any way to use it though
Okay, can you write a small guide to help reviewers test this PR?
Okay, can you write a small guide to help reviewers test this PR?
I wrote which endpoint this affects in the description now, which should make this easier to test
I already wrote that it is fine from backend side, but did you also test with packages like kernel-source meanwhile?