open-build-service
open-build-service copied to clipboard
Incoming review request missing from `/my/tasks`
Issue Description
Not all incoming review requests, that I'm allowed to accept/reject, are shown on https://build.opensuse.org/my/tasks for me. For example, request https://build.opensuse.org/request/show/1002919 is not included in the "incoming" tab (nor in osc my rq
). When I visit the url directly (or in this case via the "outgoing" tab), I can accept 1002919.
For my co-maintainers (e.g. @SchoolGuy) the issue is bigger since they obviously don't see my request in their "Outgoing Requests" tab. They only know about the request if I let them know by a different mechanism outside of OBS.
Expected Result
All incoming review requests are listed in "Incoming Requests" on https://build.opensuse.org/my/tasks.
How to Reproduce
I don't really know what caused this particular request not to show up. For me I can reproduce the view that misses the request with the below. I hope you can't follow step 1 :smile: .
- Login with my user
- Visit https://build.opensuse.org/my/tasks
- Click on "Outgoing Requests"
- See 1002919 in the list
- Click on "Incoming Requests"
- Don't see 1002919 in the list
Further Information
- Just a guess: maybe this is related to how user roles and group roles ("maintainer") are propagated in subprojects.
The problem here is that permissions to change the state of the request are bound to write permissions which you inherit from the project above (systemsmanagement:saltstack:products:testing) while what is appearing in that list is based solely the project/package this request is for (systemsmanagement:saltstack:products:testing:debian).