open-build-service icon indicating copy to clipboard operation
open-build-service copied to clipboard

[api] fix release behaviour when using token

Open adrianschroeter opened this issue 2 years ago • 1 comments

The token should also support the automatic time extension when releasing into maintenance_release projects

adrianschroeter avatar May 11 '22 09:05 adrianschroeter

Codecov Report

Merging #12563 (285ea52) into master (b3a61a0) will decrease coverage by 0.01%. The diff coverage is 73.68%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12563      +/-   ##
==========================================
- Coverage   88.22%   88.20%   -0.02%     
==========================================
  Files         711      711              
  Lines       24231    24243      +12     
==========================================
+ Hits        21377    21384       +7     
- Misses       2854     2859       +5     

codecov[bot] avatar May 11 '22 09:05 codecov[bot]

Review app will appear here: http://obs-reviewlab.opensuse.org/adrianschroeter-fix_token_release

obs-bot avatar Dec 29 '22 15:12 obs-bot

I added a couple of commits to solve the RuboCop offenses, and another one to add the basis of the documentation of the newly introduced parameters.

Feel free to complete the documentation, modifying each TODO line and merging the commits. After that the PR should be ready to be reviewed.

eduardoj avatar Dec 29 '22 15:12 eduardoj

please do not remove it or I have to rework it again ... I will add the other part to make this working.

adrianschroeter avatar Jan 16 '23 12:01 adrianschroeter

@adrianschroeter since this is replaced by https://github.com/openSUSE/open-build-service/pull/13701 I would close this PR if that alright for you?

krauselukas avatar Jan 19 '23 16:01 krauselukas

On Donnerstag, 19. Januar 2023, 17:21:52 CET Lukas Krause wrote:

@adrianschroeter since this is replaced by https://github.com/openSUSE/open-build-service/pull/13701 I would close this PR if that alright for you?

sure

--

Adrian Schroeter @.***> Build Infrastructure Project Manager

SUSE Software Solutions Germany GmbH, Frankenstraße 146, 90461 Nürnberg, Germany (HRB 36809, AG Nürnberg) Geschäftsführer: Ivo Totev

adrianschroeter avatar Jan 19 '23 16:01 adrianschroeter

Closing since this is replaced by https://github.com/openSUSE/open-build-service/pull/13701

danidoni avatar Jan 20 '23 09:01 danidoni