open-build-service icon indicating copy to clipboard operation
open-build-service copied to clipboard

fix spider test again

Open bugfinder opened this issue 3 years ago • 3 comments

Replace this line with a description of your changes. Please follow the suggestions in the comment below.


If this PR requires any particular action or consideration before deployment, please check the reasons or add your own to the list:

  • [ ] Requires a database migration that can cause downtime. Postpone deployment until maintenance window[1].
  • [ ] Contains a data migration that can cause temporary inconsistency, so should be run at a specific point of time.
  • [ ] Changes some configuration files (e.g. options.yml), so the changes have to be applied manually in the reference server.
  • [ ] A new Feature Toggle[2] should be enabled in the reference server.
  • [ ] Proper documentation or announcement has to be published upfront since the introduced changes can confuse the users.

[1] https://github.com/openSUSE/open-build-service/wiki/Deployment-of-build.opensuse.org#when-there-are-migrations [2] https://github.com/openSUSE/open-build-service/wiki/Feature-Toggles-%28Flipper%29#you-want-real-people-to-test-your-feature

bugfinder avatar Mar 29 '21 11:03 bugfinder

I'm a bit lost here... The spider specs are passing on master. Why is this change needed?

dmarcoux avatar Mar 29 '21 11:03 dmarcoux

all these fixes along these lines are spurious fails, packages and projects already deleted and still found in the spider crawl probably because of some caching. It also depends on timing and number of threads/cpus you have during the test. this one reproducibly failed today in IBS SLE-15-SP3 builds

bugfinder avatar Mar 29 '21 12:03 bugfinder

What is the error message? It seems like the package is not branched correctly.

dmarcoux avatar Mar 29 '21 12:03 dmarcoux

Codecov Report

Merging #10949 (a6568f1) into master (aeb9d8e) will increase coverage by 0.88%. The diff coverage is n/a.

:exclamation: Current head a6568f1 differs from pull request most recent head ec2a4e6. Consider uploading reports for the commit ec2a4e6 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10949      +/-   ##
==========================================
+ Coverage   87.89%   88.77%   +0.88%     
==========================================
  Files         737      688      -49     
  Lines       24786    23627    -1159     
==========================================
- Hits        21786    20976     -810     
+ Misses       3000     2651     -349     

codecov[bot] avatar May 23 '23 15:05 codecov[bot]

closing, we are way past SLE-15-SP3 and it still works on master...

hennevogel avatar May 23 '23 15:05 hennevogel