obs-service-tar_scm icon indicating copy to clipboard operation
obs-service-tar_scm copied to clipboard

strange tagging in git results in unusable version

Open birkenfeld opened this issue 9 years ago • 1 comments

When you do strange things like lightweight-tagging an annotated tag object, you get output from git describe like so:

$ git describe --tags --abbrev=0
warning: tag '1.0.0' is really 'v1.0.0' here
1.0.0

tar_scm currently just takes this whole output, including the newline, as the parent tag, which is suboptimal.

The warning is printed to stderr, so it would seem to be better not to use stderr=STDOUT in the subprocess call. Alternatively, error out in these cases.

birkenfeld avatar Jun 09 '16 18:06 birkenfeld

Yes I agree; thanks for the report. PRs welcome.

aspiers avatar Jun 21 '16 11:06 aspiers