obs-build icon indicating copy to clipboard operation
obs-build copied to clipboard
verified publisher icon openSUSE

vc - do not break hardlinks

Open sleep-walker opened this issue 8 years ago • 4 comments

some packages like kernel use hardlinks for changelogs

vc breaks it - this patch address it

sleep-walker avatar Jun 19 '17 12:06 sleep-walker

hm, don't like it much since it is no atomic operation anymore.

Also, where do you use vc? OBS interface does not support hardlinks either, so where would this be useful?

adrianschroeter avatar Jun 19 '17 13:06 adrianschroeter

  1. It wasn't much atomic operation before unless you have /tmp in same filesystem as your package. If you know how to atomically update hardlink, please tell me and I'll update the patch. Otherwise this fixes bug which is not corner case compared to requirement of atomic operation.
  2. vc is called from osc vc which is used quite a lot
  3. As I already said, kernel-* packages use that for changelogs in all SLE products.

sleep-walker avatar Jun 19 '17 13:06 sleep-walker

I have to investigate, which part of the tools we use is responsible for doing hardlinks.

sleep-walker avatar Jun 19 '17 13:06 sleep-walker

Also, where do you use vc? OBS interface does not support hardlinks either, so where would this be useful?

It seems that hardlinking is done on our side for the changelogs - if the changelogs are identical on package creation, we make them hardlinks. After that editing one causes editing all.

sleep-walker avatar Jun 20 '17 06:06 sleep-walker