snpr icon indicating copy to clipboard operation
snpr copied to clipboard

WORK IN PROGRESS - Show genotype parsing status to users

Open tsujigiri opened this issue 8 years ago • 7 comments

tsujigiri avatar Jan 04 '18 09:01 tsujigiri

Just curious... what is currently holding this up? It'd be really nice to have this!

I'm thinking about just merging it into my local copy... is it functionally in pretty good shape?

AndrewJDR avatar Mar 27 '18 04:03 AndrewJDR

What's holding this up is time constraints on my part and I think making decisions. See these comments. Feel free to continue working on this. It would be a great help!

@philippbayer @gedankenstuecke Or what do you think?

tsujigiri avatar Mar 27 '18 10:03 tsujigiri

Oh, totally agree, all contributions are welcome! 👍

gedankenstuecke avatar Mar 27 '18 11:03 gedankenstuecke

All contributions are good! To continue the old thread, how about for now we delete the genotyping, finish this, and then decide what to do with the errors?

philippbayer avatar Mar 27 '18 13:03 philippbayer

You mean deleting the files themselves or just the objects and re-parsing them?

gedankenstuecke avatar Mar 27 '18 20:03 gedankenstuecke

So far we completely delete the Genotype records, if parsing fails. This doesn't work well with showing their error status in the list of the user's uploaded genotypes. Keeping the files also isn't useful, I guess, so one way of dealing with this would be to keep the records, delete the file, and filter by success status in all other places.

tsujigiri avatar Mar 27 '18 21:03 tsujigiri

Ah, my bad. I'm too jet lagged for this. I was mentally still at the zip/gzip/etc. issue and how to work with the files we already have that are acting up. 😂

gedankenstuecke avatar Mar 27 '18 21:03 gedankenstuecke