web-app icon indicating copy to clipboard operation
web-app copied to clipboard

.travis.yml uses "npm run build:prod" but README says to use "ng build"

Open vorburger opened this issue 4 years ago • 6 comments

https://github.com/openMF/web-app/blob/master/.travis.yml#L14 currently uses:

npm run build:prod

but https://github.com/openMF/web-app#build documentation suggests to use:

ng build

This seems inconsistent (to a noob). Which one is correct?

PS: Also the npm run build:prod produces a weird index.html containing a <base href="/web-app/">, which seems broken. The dist/index.html produced by ng build seems to work better.

vorburger avatar May 06 '20 01:05 vorburger

@vorburger kindly see #436 and #437

karantakalkar avatar May 06 '20 07:05 karantakalkar

I guess we need to update docs

karantakalkar avatar May 06 '20 07:05 karantakalkar

@vorburger It has been done to create a production build with Travis and deploy it to Github pages due to which it is different. Due to the large size of the project we also had to increase the heap size for the production build as notified by Karan above . Although, we should mention the difference in README.md to avoid the confusion.

abhaychawla avatar May 06 '20 07:05 abhaychawla

@karantakalkar can I work on this issue, if so do assign me, I will review the docs and change at appropriate places.

shobhi1310 avatar Oct 31 '20 08:10 shobhi1310

I can help with this.

shubhamkorde avatar Jan 12 '21 04:01 shubhamkorde

I can help with this.

I can help with this too. Please let me know!!

vinmehta16 avatar May 18 '21 16:05 vinmehta16