web-app
web-app copied to clipboard
.travis.yml uses "npm run build:prod" but README says to use "ng build"
https://github.com/openMF/web-app/blob/master/.travis.yml#L14 currently uses:
npm run build:prod
but https://github.com/openMF/web-app#build documentation suggests to use:
ng build
This seems inconsistent (to a noob). Which one is correct?
PS: Also the npm run build:prod
produces a weird index.html containing a <base href="/web-app/">
, which seems broken. The dist/index.html
produced by ng build
seems to work better.
@vorburger kindly see #436 and #437
I guess we need to update docs
@vorburger It has been done to create a production build with Travis and deploy it to Github pages due to which it is different. Due to the large size of the project we also had to increase the heap size for the production build as notified by Karan above . Although, we should mention the difference in README.md
to avoid the confusion.
@karantakalkar can I work on this issue, if so do assign me, I will review the docs and change at appropriate places.
I can help with this.
I can help with this.
I can help with this too. Please let me know!!