web-app icon indicating copy to clipboard operation
web-app copied to clipboard

WEB-379 replace custom api of system.service.ts

Open JaySoni1 opened this issue 1 month ago • 6 comments

Replaced custom methods in *.ts files that were previously using SystemService with their corresponding auto-generated methods from the OpenAPI-based @fineract/client package .

WEB-379

JaySoni1 avatar Nov 12 '25 20:11 JaySoni1

[!IMPORTANT]

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (1)
  • dev

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

[!NOTE]

.coderabbit.yaml has unrecognized properties

CodeRabbit is using all valid settings from your configuration. Unrecognized properties (listed below) have been ignored and may indicate typos or deprecated fields that can be removed.

⚠️ Parsing warnings (1)
Validation error: Unrecognized key(s) in object: 'pre_merge_checks'
⚙️ Configuration instructions
  • Please see the configuration documentation for more information.
  • You can also validate your configuration using the online YAML validator.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
✨ Finishing touches
🧪 Generate unit tests (beta)
  • [ ] Create PR with unit tests
  • [ ] Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot] avatar Nov 12 '25 20:11 coderabbitai[bot]

@gkbishnoi07 @steinwinde Please Review

JaySoni1 avatar Nov 12 '25 20:11 JaySoni1

https://github.com/user-attachments/assets/9ccaeb15-1318-4bce-bbe9-439264a98096

gkbishnoi07 avatar Nov 21 '25 22:11 gkbishnoi07

https://github.com/user-attachments/assets/6d2ae9c1-c854-48fe-ae78-83365e9c3eed

gkbishnoi07 avatar Nov 21 '25 22:11 gkbishnoi07

@gkbishnoi07 I have update the PR please review

JaySoni1 avatar Nov 22 '25 21:11 JaySoni1

ok

gkbishnoi07 avatar Nov 28 '25 12:11 gkbishnoi07

@gkbishnoi07 I have a few doubts regarding this PR, so I have messaged you on Slack. Please check

JaySoni1 avatar Dec 17 '25 20:12 JaySoni1