web-app icon indicating copy to clipboard operation
web-app copied to clipboard

WEB-340 replace custom api of saving.service.ts

Open JaySoni1 opened this issue 2 months ago • 7 comments

Replaced custom methods in *.ts files that were previously using SavingService with their corresponding auto-generated methods from the OpenAPI-based @fineract/client package.

JaySoni1 avatar Oct 21 '25 22:10 JaySoni1

[!IMPORTANT]

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • [ ] Create PR with unit tests
  • [ ] Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot] avatar Oct 21 '25 22:10 coderabbitai[bot]

@gkbishnoi07 Please Review

JaySoni1 avatar Oct 21 '25 22:10 JaySoni1

Okay

gkbishnoi07 avatar Oct 22 '25 08:10 gkbishnoi07

@gkbishnoi07 , I assume that your comment means that you are still reviewing this? I don't want to appear pushy - just want to make sure I understand your comment.

steinwinde avatar Oct 29 '25 13:10 steinwinde

image

cannot create saving account getting error

gkbishnoi07 avatar Oct 31 '25 13:10 gkbishnoi07

@gkbishnoi07 I have update the PR please review .

JaySoni1 avatar Nov 03 '25 22:11 JaySoni1

This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days.

github-actions[bot] avatar Dec 12 '25 01:12 github-actions[bot]

@gkbishnoi07 I have a few doubts regarding this PR, so I have messaged you on Slack. Please check

JaySoni1 avatar Dec 17 '25 20:12 JaySoni1