web-app Possible resolution to web-100.

Provides possible resolution to web-100. 'No account' messages are displayed in whichever language is required, if there are no accounts of that type available.

[*] If you have multiple commits please combine them into one commit by squashing them.
[*] Read and understood the contribution guidelines at web-app/.github/CONTRIBUTING.md.

Summary by CodeRabbit

New Features
- Added empty-state messages for Loan, Saving, Fixed Deposit, Recurring Deposit and Shares accounts in the client overview.
Style
- Introduced a visible no-account message style for empty-state notices.
Localization
- Updated many locales: added multiple "No … accounts" strings and a refund-related message; removed and consolidated numerous translation keys (several principal/amount, password, collection-sheet and related entries).

_{✏️ Tip: You can customize this high-level summary in your review settings.}

Sep 09 '25 19:09 mjpugh811

[!WARNING]

Rate limit exceeded

@mjpugh811 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 0 minutes and 11 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between b673d0f0899252e50ec09ae921ae0d50935a4f73 and a864adca8a47be97c35acc004c01ae8b8019d1a9.

📒 Files selected for processing (15)

src/app/clients/clients-view/general-tab/general-tab.component.html (5 hunks)

src/app/clients/clients-view/general-tab/general-tab.component.scss (1 hunks)

src/assets/translations/cs-CS.json (7 hunks)

src/assets/translations/de-DE.json (5 hunks)

src/assets/translations/en-US.json (2 hunks)

src/assets/translations/es-CL.json (5 hunks)

src/assets/translations/es-MX.json (5 hunks)

src/assets/translations/fr-FR.json (5 hunks)

src/assets/translations/it-IT.json (5 hunks)

src/assets/translations/ko-KO.json (5 hunks)

src/assets/translations/lt-LT.json (5 hunks)

src/assets/translations/lv-LV.json (5 hunks)

src/assets/translations/ne-NE.json (5 hunks)

src/assets/translations/pt-PT.json (5 hunks)

src/assets/translations/sw-SW.json (5 hunks)

Walkthrough

Adds empty-state conditional markup to the client General tab template, a new .no-account-message style, and updates many locale JSON files to add “No … accounts” and a refund-related translation while removing/consolidating various legacy translation keys.

Changes

Cohort / File(s)	Summary of Changes
Client General Tab Template `src/app/clients/clients-view/general-tab/general-tab.component.html`	Inserted conditional empty-state markup blocks for Loan, Savings, Fixed Deposit, Recurring Deposit, and Shares sections (renders `.no-account-message` when respective lists/filters are empty); multiple commented-out blocks added.
Client General Tab Styles `src/app/clients/clients-view/general-tab/general-tab.component.scss`	Added comment and new `.no-account-message` CSS rule (`color: blue;`).
English translations `src/assets/translations/en-US.json`	Added empty-state keys: `No deposit accounts`, `No loan accounts`, `No recurring accounts`, `No saving accounts`, `No shares accounts`.
Locale translations — Additions `src/assets/translations/{cs-CS.json, de-DE.json, es-CL.json, es-MX.json, fr-FR.json, it-IT.json, ko-KO.json, lt-LT.json, lv-LV.json, ne-NE.json, pt-PT.json, sw-SW.json, ...}`	Added localized `No ... accounts` entries and the message `Refund transactions where interest refund will automatically be calculated` across multiple locale files.
Locale translations — Removals / Consolidation `src/assets/translations/{cs-CS.json, de-DE.json, es-CL.json, es-MX.json, fr-FR.json, it-IT.json, ko-KO.json, lt-LT.json, lv-LV.json, ne-NE.json, pt-PT.json, sw-SW.json, ...}`	Removed or consolidated numerous legacy translation keys (examples: `Create Interest Refund`, `Productive Collection Sheet`, multiple amortization/amount/date keys, password-related keys, `Collection Sheet`, and other legacy entries).

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Verify template bindings: accountsFilter, loanAccounts, shareAccounts and conditional expressions.
Search for usages of removed translation keys across templates/components and update references.
Confirm .no-account-message styling, contrast and accessibility.

Suggested reviewers

steinwinde
shubhamkumar9199
gkbishnoi07

Poem

I nibble at markup where empty burrows hide,
Blue letters peep where account lists died,
In many tongues I hum a gentle tune,
“No loans, no shares” beneath the moon,
A rabbit hops — the UI feels light. 🐇

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title 'Possible resolution to web-100' is vague and does not clearly convey the main change. While it references an issue number, it provides no meaningful information about what the PR actually accomplishes without consulting external context.	Replace with a more descriptive title that clearly indicates the primary change, such as 'Add empty-state messages for account types across all locales' or similar.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Sep 30 '25 19:09 coderabbitai[bot]

Sorry to say, but I've just asked Google translate for two of the suggested translations that coderabbitai critisized as being in the wrong language. And according to Google translate, the new translations are indeed in the wrong language. Please go through the AI criticism of your PR and correct what is to be corrected.

Oct 19 '25 09:10 steinwinde

@mjpugh811 , what is the status of this?

Oct 29 '25 12:10 steinwinde

This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days.

Nov 29 '25 01:11 github-actions[bot]