web-app icon indicating copy to clipboard operation
web-app copied to clipboard

Published 20 hours ago • verified publisher icon openMF

feat: Create dialog for users to add/remove custom servers

Open sankha555 opened this issue 4 years ago • 8 comments

Feat: Create dialog for users to add/remove custom servers

Description

Created a new dialog component "Custom Server Component" under Server Selector component to add custom servers to a table and display the table in the dialog box. Added servers can also be deleted from the table. Selected servers in the table are added to the list of mifosXServers in localstorage using the settings service. This will help users to add and store custom servers to run the web app.

Related issues and discussion

Fixes #1273

Screenshots

New custom server dialog box Screenshot 2020-12-26 at 4 30 06 PM

Added a new custom dummy server "https://mifos.xoxo" to the custom servers table Screenshot 2020-12-26 at 4 30 34 PM

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • [x] If you have multiple commits please combine them into one commit by squashing them.

  • [x] Read and understood the contribution guidelines at web-app/.github/CONTRIBUTING.md.

sankha555 avatar Dec 26 '20 11:12 sankha555

@BLasan Made the required changes. Please review. Thanks!

sankha555 avatar Dec 26 '20 14:12 sankha555

@sankha555 Add an empty line at the end of the code. This empty line must be presented in all ts,html and scss files

@BLasan I think I had already added the required newlines to all the files in commit 67797f02ddb60b1f10824d8b38b2eb5564ab29e6 in response to the changes suggested by you yesterday. Please take a look at it

sankha555 avatar Dec 27 '20 06:12 sankha555

@sankha555 Add an empty line at the end of the code. This empty line must be presented in all ts,html and scss files

@BLasan I think I had already added the required newlines to all the files in commit 67797f0 in response to the changes suggested by you yesterday. Please take a look at it

Thanks. We have to wait until @karantakalkar review and approve this PR

BLasan avatar Dec 27 '20 07:12 BLasan

Thanks @BLasan ! @karantakalkar kindly take a look if you find time and provide your feedback about the utility of the PR and possible merging of the PR. It would be really helpful for me in future contributions. Thanks in advance!

sankha555 avatar Dec 27 '20 08:12 sankha555

LGTM, but we will need to wait till travis builds are back.

karantakalkar avatar Dec 29 '20 14:12 karantakalkar

LGTM, but we will need to wait till travis builds are back.

Travis builds are now migrated to one time free plan of 10k credits aka 1k Linux builds only. After this, you have to move to one of the paid plans. It would be better if you move to Github Actions. I would be happy to push a pr, just did it for my company.

Abhirup-99 avatar Dec 29 '20 15:12 Abhirup-99

1 commit per pr, please squash them.

Abhirup-99 avatar Jan 09 '21 10:01 Abhirup-99

@BLasan Made the required changes. Please review. Thanks!

shall we squash the commits and rename the commit message as feat: Create dialog for users to add/remove custom servers

BLasan avatar Jan 09 '21 11:01 BLasan

This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days.

github-actions[bot] avatar Sep 02 '22 01:09 github-actions[bot]