web-app
web-app copied to clipboard
openMF
Predictive text input on Accounting Section for Products creation
Goal:
As a user I want to be able to type a GL name / gl_code so that I can filter the list of the GLs when in-putting the GL information under the accounting section of the Product (all products) - API https://localhost/products/saving-products/create
i.e.
Hey @Abhirup-99 I kind of also worked on this issue sometime back (last year :-) ), almost halfway done and would like to continue if that's not an issue. Thanks
@ksraj123 Mate, the issue was opened on Dec 5th. How could you have worked on it before? And if that was the case shouldn't you have mentioned it in the issue at least.
@Abhirup-99 yeah, I forked the repo yesterday to make my first PR. Originally cloned this to my local machine sometime back to explore the codebase, tried to work on this issue for a bit as it seemed interesting. Already shared the state I left my work in. Btw, there's plenty of room for everyone to contribute. We are all here to learn. You are free to work on this, if you want to.
Also by last year, I meant December.
@ksraj123 Mate, the issue was opened on Dec 5th. How could you have worked on it before? And if that was the case shouldn't you have mentioned it in the issue at least.
I guess this point still remains valid, no matter when you have cloned it. And I agree we are here to learn but it would more of a community rules-based approach, rather than other means. Peace :v:
I guess this point still remains valid, no matter when you have cloned it.
@Abhirup-99 I don't understand, does December 2020 not count as last year?. I too think not really, hence the smiley after "last year" in my original comment.
You can take this up if you really find this interesting.
Apologies for not commenting sooner, just got to learn this yesterday that we need to comment first. Will keep in mind from next time.
I guess this point still remains valid, no matter when you have cloned it.
@Abhirup-99 I don't understand, does December 2020 not count as last year?. I too think not really, hence the smiley after "last year" in my original comment.
You can take this up if you really find this interesting.
Apologies for not commenting sooner, just got to learn this yesterday that we need to comment first. Will keep in mind from next time.
The issue wasn't specifically about December as being a part of last year or my love for this particular issue, it was the approach. Regardless, peace :v:
Hey @Abhirup-99 I kind of also worked on this issue sometime back (last year :-) ), almost halfway done and would like to continue if that's not an issue. Thanks
Yes @ksraj123 , This is what i meant - by predictive text input with account numbers showing on the GL names. Please raise a PR so that all of us can enjoy your efforts
@ksraj123 Please work 1 issue at time and don't block multiple issues for yourself currently I assume you were working on #1281. @Abhirup-99 you can look around the app and test features for bugs in case you are short on issues to work on, that would be helpful to us.
@karantakalkar yes, working on it. This needed.just a little more work so finished this first.
@francisguchie @karantakalkar Please review the PR for this. Thanks
@ksraj123 thanks for this. I will review over the weekend ( I will do a functional review ) and make my comments here