web-app icon indicating copy to clipboard operation
web-app copied to clipboard

Create dialog for users to add/remove custom servers.

Open karantakalkar opened this issue 4 years ago • 4 comments

Screenshot from 2020-11-16 22-22-41

We need a dialog that will allow users to add/remove custom servers in a table, it should open on-click a small button beside server-select field.

Refer:

  • Loan accounts table in clients view page (button)
  • Add charge stepper in create-savings-account (for table)

Add remove operations should be done on localstorage by settings service.

karantakalkar avatar Nov 19 '20 07:11 karantakalkar

@karantakalkar Can I work on this?

BLasan avatar Nov 21 '20 04:11 BLasan

Hello @karantakalkar , I would like to work on this issue if it's still open for contribution. I have gone through the codebase and have tried to understand the requirements for the task and want to give it a good attempt. Could you please assign this issue to me? Thanks!

sankha555 avatar Dec 24 '20 10:12 sankha555

Go ahead

karantakalkar avatar Dec 24 '20 10:12 karantakalkar

Hello @karantakalkar , I have made a pull request with the changes I have made to achieve the specifications in the issue. Please take a look at it and let me know your reviews and suggested changes regarding the work. Thanks!

sankha555 avatar Dec 26 '20 11:12 sankha555