web-app icon indicating copy to clipboard operation
web-app copied to clipboard

refactor: loans-general-tab & loans-transactions-tab

Open BLasan opened this issue 4 years ago • 6 comments

Description

Refactored the General Tab & Transaction Tab UIs in Clients-Loans page.

Related issues and discussion

#1249

Screenshots, if any

Screenshot from 2020-10-22 12-14-15 Screenshot from 2020-10-22 12-30-32

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • [x] If you have multiple commits please combine them into one commit by squashing them.

  • [x] Read and understood the contribution guidelines at web-app/.github/CONTRIBUTING.md.

BLasan avatar Oct 22 '20 07:10 BLasan

@karantakalkar @spider0061 Shall we review this?

BLasan avatar Oct 22 '20 08:10 BLasan

Can you make it consistent with savings account view page ? We need a bit precise refinement here.

karantakalkar avatar Jan 08 '21 08:01 karantakalkar

Hi @BLasan did you get a chance to make the changes as per the latest comment to this PR?

bharathcgowda avatar Aug 28 '21 13:08 bharathcgowda

Hi @BLasan did you get a chance to make the changes as per the latest comment to this PR?

Hi, actually didn't get a chance to do so

BLasan avatar Aug 28 '21 13:08 BLasan

@no worries @BLasan we can have a look after the GSOC work is complete :)

bharathcgowda avatar Aug 28 '21 13:08 bharathcgowda

@karantakalkar @bharathcgowda @BLasan : We are reviewing the Angular 13 PR. I want to get mergeable PRs merged into Web App before that.

Is this something that can be pulled in or needs further enhancements to make it mergeable?

avikganguly01 avatar Mar 28 '22 14:03 avikganguly01

This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days.

github-actions[bot] avatar Sep 07 '22 01:09 github-actions[bot]