web-app icon indicating copy to clipboard operation
web-app copied to clipboard

Published 20 hours ago • verified publisher icon openMF

fix(csv download): fixed csv download with commas

Open Abhirup-99 opened this issue 3 years ago • 3 comments

Fixes #1261

Description

Describe the changes made and why they were made instead of how they were made. List any dependencies that are required for this change.

Related issues and discussion

#1261

Screenshots, if any

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • [x] If you have multiple commits please combine them into one commit by squashing them.

  • [x] Read and understood the contribution guidelines at web-app/.github/CONTRIBUTING.md.

Abhirup-99 avatar Oct 18 '20 04:10 Abhirup-99

@karantakalkar please review.

Abhirup-99 avatar Oct 24 '20 12:10 Abhirup-99

Add new line at EOF

I didn't create this file. This pr was created to fix a separate issue. It would be out of context to add a new line at EOF, although I agree with it. But this goes contrary to why this pr was created. Thanks for the review though.

Abhirup-99 avatar Jan 01 '21 12:01 Abhirup-99

hi @karantakalkar can you review the changes pushed for this ticket please?

bharathcgowda avatar May 24 '22 13:05 bharathcgowda

This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days.

github-actions[bot] avatar Sep 07 '22 01:09 github-actions[bot]