web-app icon indicating copy to clipboard operation
web-app copied to clipboard

Replace multiselect by custom checkbox tree in create holiday component

Open karantakalkar opened this issue 4 years ago • 9 comments

Screenshot from 2020-08-27 18-59-04

We need to use custom made angular material checkbox tree, refer to view tree implementations in accounting section and angular material checkbox tree implementation https://material.angular.io/components/tree/examples and develop a custom solution that fits fineract APIs as well as our use case

karantakalkar avatar Aug 27 '20 13:08 karantakalkar

Can I work on this?

zerefwayne avatar Aug 28 '20 07:08 zerefwayne

Go ahead, please

karantakalkar avatar Aug 28 '20 08:08 karantakalkar

@karantakalkar can I work on this issue? It seems to be inactive for a long time.

Abhirup-99 avatar Oct 08 '20 16:10 Abhirup-99

There is an PR on this issue ask the author

karantakalkar avatar Oct 08 '20 16:10 karantakalkar

@zerefwayne this issue seems to be inactive for quite some time, would you mind if I continue working on it?

Abhirup-99 avatar Oct 08 '20 16:10 Abhirup-99

Hey, I was caught up with some work. The PR is almost complete just needs some more testing to be done. So I'll go ahead with completing it.

On Thu, 8 Oct 2020, 22:21 Abhirup Pal, [email protected] wrote:

@zerefwayne https://github.com/zerefwayne this issue seems to be inactive for quite some time, would you mind if I continue working on it?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/openMF/web-app/issues/1231#issuecomment-705695631, or unsubscribe https://github.com/notifications/unsubscribe-auth/AG43XFJN2ODFGHUURGELF4LSJXU2JANCNFSM4QM73NIA .

zerefwayne avatar Oct 08 '20 20:10 zerefwayne

Hey, I was caught up with some work. The PR is almost complete just needs some more testing to be done. So I'll go ahead with completing it. On Thu, 8 Oct 2020, 22:21 Abhirup Pal, @.***> wrote: @zerefwayne https://github.com/zerefwayne this issue seems to be inactive for quite some time, would you mind if I continue working on it? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1231 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AG43XFJN2ODFGHUURGELF4LSJXU2JANCNFSM4QM73NIA .

Ok cool. Thanks.

Abhirup-99 avatar Oct 08 '20 20:10 Abhirup-99

Since the previous pr is closed now, can I go forward with this issue? @karantakalkar

Abhirup-99 avatar Jan 08 '21 10:01 Abhirup-99

I was working on this issue, should I improve upon the work done in the previous pr or create a completely new one? @karantakalkar

Abhirup-99 avatar Jan 10 '21 12:01 Abhirup-99

Added feature. Working as Expected.

ramvr1256 avatar Sep 05 '22 11:09 ramvr1256