web-app
web-app copied to clipboard
Replace multiselect by custom checkbox tree in create holiday component
We need to use custom made angular material checkbox tree, refer to view tree implementations in accounting section and angular material checkbox tree implementation https://material.angular.io/components/tree/examples and develop a custom solution that fits fineract APIs as well as our use case
Can I work on this?
Go ahead, please
@karantakalkar can I work on this issue? It seems to be inactive for a long time.
There is an PR on this issue ask the author
@zerefwayne this issue seems to be inactive for quite some time, would you mind if I continue working on it?
Hey, I was caught up with some work. The PR is almost complete just needs some more testing to be done. So I'll go ahead with completing it.
On Thu, 8 Oct 2020, 22:21 Abhirup Pal, [email protected] wrote:
@zerefwayne https://github.com/zerefwayne this issue seems to be inactive for quite some time, would you mind if I continue working on it?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/openMF/web-app/issues/1231#issuecomment-705695631, or unsubscribe https://github.com/notifications/unsubscribe-auth/AG43XFJN2ODFGHUURGELF4LSJXU2JANCNFSM4QM73NIA .
Hey, I was caught up with some work. The PR is almost complete just needs some more testing to be done. So I'll go ahead with completing it. … On Thu, 8 Oct 2020, 22:21 Abhirup Pal, @.***> wrote: @zerefwayne https://github.com/zerefwayne this issue seems to be inactive for quite some time, would you mind if I continue working on it? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1231 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AG43XFJN2ODFGHUURGELF4LSJXU2JANCNFSM4QM73NIA .
Ok cool. Thanks.
Since the previous pr is closed now, can I go forward with this issue? @karantakalkar
I was working on this issue, should I improve upon the work done in the previous pr or create a completely new one? @karantakalkar
Added feature. Working as Expected.