mobile-wallet
mobile-wallet copied to clipboard
Feat: refurbished the entire setting page
Feat: #784 Refurbished the entire settings page, with the PreferenceCategory. Used the preference_category in xml and updated the fragment and called in activity
Working video:
-
[.] Apply the
AndroidStyle.xml
style template to your code in Android Studio. -
[.] Run the unit tests with
./gradlew check
to make sure you didn't break anything -
[.] If you have multiple commits please combine them into one commit by squashing them.
@naman14 @luckyman20 @shiv07tiwari @droidchef Please review this!!
You forgot the logout button
@dubeyaayush07 Yess, thank you for noticing!
@Bhavnaharitsa Please add the updated screenshot.
@shiv07tiwari Sir, about that. Apparently the PreferenceFragment that I used is dedicated for android and only available in Androidx. So, can we, with your permission migrate to Androidx as we might loose a lot of libraries if we still sustain in Android.
@Bhavnaharitsa Any updates on this?
@shiv07tiwari @luckyman20 @rachittt As we all know, the settings page mobile wallet has is not like the conventional one in other apps which is the reason I opened this pr. But, what I have learned is that we don't use AndroidX and the Preference feature works on AndroidX alone as it has been deprecated in Android now. If there is any task as such to migrate the project to AndroidX, I will be happy to take up and convert this settings page too along with it :)
@Bhavnaharitsa Adding androidX gives error with Dagger, last time I checked @shiv07tiwari was working on it.
@Bhavnaharitsa @luckyman20 @shiv07tiwari @devansh-299 Can i take up this issue?Is the pull request faulty?Please let me know
Unrelated and not needed anymore