mobile-wallet icon indicating copy to clipboard operation
mobile-wallet copied to clipboard

Feat: refurbished the entire setting page

Open Bhavnaharitsa opened this issue 4 years ago • 9 comments

Feat: #784 Refurbished the entire settings page, with the PreferenceCategory. Used the preference_category in xml and updated the fragment and called in activity

Working video: ezgif com-video-to-gif

  • [.] Apply the AndroidStyle.xml style template to your code in Android Studio.

  • [.] Run the unit tests with ./gradlew check to make sure you didn't break anything

  • [.] If you have multiple commits please combine them into one commit by squashing them.

Bhavnaharitsa avatar Mar 02 '20 15:03 Bhavnaharitsa

@naman14 @luckyman20 @shiv07tiwari @droidchef Please review this!!

Bhavnaharitsa avatar Mar 02 '20 15:03 Bhavnaharitsa

You forgot the logout button

dubeyaayush07 avatar Mar 04 '20 16:03 dubeyaayush07

@dubeyaayush07 Yess, thank you for noticing!

Bhavnaharitsa avatar Mar 05 '20 03:03 Bhavnaharitsa

@Bhavnaharitsa Please add the updated screenshot.

shiv07tiwari avatar Mar 10 '20 17:03 shiv07tiwari

@shiv07tiwari Sir, about that. Apparently the PreferenceFragment that I used is dedicated for android and only available in Androidx. So, can we, with your permission migrate to Androidx as we might loose a lot of libraries if we still sustain in Android.

Bhavnaharitsa avatar Mar 10 '20 17:03 Bhavnaharitsa

@Bhavnaharitsa Any updates on this?

shiv07tiwari avatar May 19 '20 18:05 shiv07tiwari

@shiv07tiwari @luckyman20 @rachittt As we all know, the settings page mobile wallet has is not like the conventional one in other apps which is the reason I opened this pr. But, what I have learned is that we don't use AndroidX and the Preference feature works on AndroidX alone as it has been deprecated in Android now. If there is any task as such to migrate the project to AndroidX, I will be happy to take up and convert this settings page too along with it :)

Bhavnaharitsa avatar Jun 01 '20 09:06 Bhavnaharitsa

@Bhavnaharitsa Adding androidX gives error with Dagger, last time I checked @shiv07tiwari was working on it.

luckyman20 avatar Jun 01 '20 12:06 luckyman20

@Bhavnaharitsa @luckyman20 @shiv07tiwari @devansh-299 Can i take up this issue?Is the pull request faulty?Please let me know

haran2248 avatar Feb 05 '21 19:02 haran2248

Unrelated and not needed anymore

therajanmaurya avatar Mar 03 '24 06:03 therajanmaurya