mobile-wallet icon indicating copy to clipboard operation
mobile-wallet copied to clipboard
Published 2 months ago • verified publisher icon openMF

New UI to change password

Open rodrigosouzalopes94 opened this issue 1 year ago • 14 comments

Issue Fix

Fixes #{Issue Number} Jira Task: [MW145]https://mifosforge.jira.com/browse/MW-148

Screenshots

New Screen Old Screen
print_MW145 old_screen_password

Description

A new change password screen

  • [x] Apply the AndroidStyle.xml style template to your code in Android Studio.

  • [x] Run the unit tests with ./gradlew check to make sure you didn't break anything

  • [x] If you have multiple commits please combine them into one commit by squashing them.

rodrigosouzalopes94 avatar Oct 04 '24 22:10 rodrigosouzalopes94

Run ci-prepush.sh bash script before commiting or pushing your changes it will format and check for any errors

niyajali avatar Oct 05 '24 05:10 niyajali

Can you upload both Old UI and Updated UI Image

niyajali avatar Oct 05 '24 05:10 niyajali

Commit your changes, i didn't see any

niyajali avatar Oct 05 '24 14:10 niyajali

@rodrigosouzalopes94 fix this build error

Task :core:designsystem:compileDemoDebugKotlin FAILED e: file:///home/runner/work/mobile-wallet/mobile-wallet/core/designsystem/src/main/kotlin/org/mifospay/core/designsystem/component/TextField.kt:119:25 Unresolved reference 'NewUi'.

niyajali avatar Oct 07 '24 12:10 niyajali

Hello @rodrigosouzalopes94 , thanks for the PR but You modified the old OutlinedTextField and set colors to color.Transparent. We won't be using that anymore.

Take reference from finance/payment/editProfile screen. also after you are done please attach the figma UI as well

Can you help to make the clean code about these styles?

rodrigosouzalopes94 avatar Oct 07 '24 21:10 rodrigosouzalopes94

Can you help to make the clean code about these styles?

it's not about styles, You need to modify MifosTextField that we already have in textfield.kt file. If you still have any doubts feel free to let me know on Slack.

itsPronay avatar Oct 08 '24 10:10 itsPronay

Done.

rodrigosouzalopes94 avatar Oct 09 '24 09:10 rodrigosouzalopes94

Done.

  1. please update the new UI in your commit message. also, add Figma UI as well
  2. fix conflicts
  3. Please squash your commits as well (squash before pulling the remote changes) image

itsPronay avatar Oct 09 '24 11:10 itsPronay

Figma UI image New Screen newUI

rodrigosouzalopes94 avatar Oct 09 '24 22:10 rodrigosouzalopes94

@rodrigosouzalopes94 As I can see, the trailing icon color doesn't match the color as per Figma UI

niyajali avatar Oct 10 '24 13:10 niyajali

I gonna fixed.

rodrigosouzalopes94 avatar Oct 10 '24 20:10 rodrigosouzalopes94

@rodrigosouzalopes94 take a look into this pr #1787 , might helps

niyajali avatar Oct 11 '24 14:10 niyajali

@niyajali can you help @rodrigosouzalopes94 so we can merge this PR

therajanmaurya avatar Oct 18 '24 03:10 therajanmaurya

@rodrigosouzalopes94 Here is the pr #1787 of this module

niyajali avatar Oct 18 '24 08:10 niyajali

Already Implemented

therajanmaurya avatar Jan 30 '25 04:01 therajanmaurya