mobile-wallet icon indicating copy to clipboard operation
mobile-wallet copied to clipboard

text view bug fixed #1250

Open Supriyo9 opened this issue 3 years ago • 5 comments

Issue Fix

Fixes #1250

Screenshots

1614598456600

Description

In Sign Up Xml file text view of id "android:id="@+id/tv_password_strength" which was showing "weak, strong , very strong and password should contain 6 characters " was getting overlapped sometimes with the confirm password edit text or sometime with progress bar just above it. #1250

  • [x] Apply the AndroidStyle.xml style template to your code in Android Studio.

  • [x] Run the unit tests with ./gradlew check to make sure you didn't break anything

  • [x] If you have multiple commits please combine them into one commit by squashing them.

Supriyo9 avatar Mar 05 '21 11:03 Supriyo9

I can't see any issue in your commit that shows why this test is failing, @devansh-299 @s-ayush2903 can you guys tell what's the issue here. I checked details of test fail it shows "core: 'annotationProcessor' dependencies won't be recognized as kapt annotation processors. Please change the configuration name to 'kapt' for these artifacts: 'com.google.dagger:dagger-compiler:2.11'.".

EGOR-IND avatar Mar 05 '21 11:03 EGOR-IND

Please follow the PR guidelines and add screenshots whenver you make UI changes

haran2248 avatar Mar 06 '21 12:03 haran2248

Use '<'img src="link_of_image" width="200" height="400"'>' to upload a photo, this will adjust the image to viewable size.😊

EGOR-IND avatar Mar 06 '21 12:03 EGOR-IND

, @devansh-299 @s-ayush2903 can you guys tell what's the issue here.

Hmm, now it seems weird to me as it is failing everywhere(at mobile-wallet new PRs). Btw thanks for the ping, I'll investigate and push a fix

s-ayush2903 avatar Mar 07 '21 11:03 s-ayush2903

, @devansh-299 @s-ayush2903 can you guys tell what's the issue here.

Hmm, now it seems weird to me as it is failing everywhere(at mobile-wallet new PRs). Btw thanks for the ping, I'll investigate and push a fix

Thank you @s-ayush2903 please make it as soon as possible.It would be useful for future contributions:)

haran2248 avatar Mar 07 '21 12:03 haran2248

We are using compose now

therajanmaurya avatar Mar 03 '24 05:03 therajanmaurya