mobile-wallet icon indicating copy to clipboard operation
mobile-wallet copied to clipboard

Add feature to open the receipt link in browser.

Open EGOR-IND opened this issue 4 years ago • 6 comments

Summary:

The receipt link given in receipt activity is not doing anything by itself, it even has the color of a link which makes it look like a working link to a user, but it's not clickable.

Steps to reproduce:

  1. Go to receipt activity
  2. click on receipt link

Expected behavior:

It should open that link in a browser.

Observed behavior:

Right now it's not clickable.

Device and Android version:

VIVOY83, Android Version = 8.1.0

Screenshots:

EGOR-IND avatar Feb 10 '21 16:02 EGOR-IND

I'm working on this issue.

EGOR-IND avatar Feb 10 '21 16:02 EGOR-IND

@haran2248 @devansh-299 can you give your views on this issue.

EGOR-IND avatar Feb 10 '21 17:02 EGOR-IND

Actually the given link is just a deeplink even if you make it open in the browser it is of no use i guess.Only if the person has the app the deeplink will open.But in this case the share and copy feature has been implemented so i think it is of no use. @divyank00 @devansh-299 Please confirm

haran2248 avatar Feb 11 '21 08:02 haran2248

Yes it is a deeplink though, but the link is actually there and even if we share or copy it what use will it be, I was actually thinking that if we're copying and sharing the link then there should be a way of accessing that link through app.

EGOR-IND avatar Feb 11 '21 09:02 EGOR-IND

Yeah but if you put it in a browser.It will show invalid address.If the user has the app it will open in the app.Opening it through chrome Im not sure if it is a good idea,But you can try making a PR anyway,It might be useful :)

haran2248 avatar Feb 11 '21 13:02 haran2248

No I'm saying we should open it in the app, there is a way I think to open a deeplink in the app. Let me do some research on it and then we'll talk😊.

EGOR-IND avatar Feb 11 '21 14:02 EGOR-IND