mobile-wallet icon indicating copy to clipboard operation
mobile-wallet copied to clipboard

Published 20 hours ago • verified publisher icon openMF

Remove All hardcoded strings

Open deepak-prajapatii opened this issue 4 years ago • 10 comments

Issue Fix

Fixes #1090

Description

Remove all Hardcoded Strings and warnings as much as possible.

  • [x] Apply the AndroidStyle.xml style template to your code in Android Studio.

  • [x] Run the unit tests with ./gradlew check to make sure you didn't break anything

  • [x] If you have multiple commits please combine them into one commit by squashing them.

deepak-prajapatii avatar Jan 20 '21 07:01 deepak-prajapatii

@Nayan @siebrand @vorburger @vishwasbabu @EGOR-IND Please review my PR ASAP.

deepak-prajapatii avatar Jan 20 '21 07:01 deepak-prajapatii

@deepak-prajapatii As per comments on PRs, I'm not maintaining this project, and cannot help review PRs in this repo. Please stop "tagging" me.

It looks like @devansh-299 is an active committer in this project. I'm sure he will review and get back to you when he can.

If there's not enough active committers on this project, then the "right" thing to do in open source could be for the existing committers to invite new people who recently contributed quality to become additional committers... would this potentially interest you? You could write to the [email protected] mailing list to discuss that, if taking on this responsability interests you.

vorburger avatar Jan 20 '21 09:01 vorburger

@deepak-prajapatii As per comments on PRs, I'm not maintaining this project, and cannot help review PRs in this repo. Please stop "tagging" me.

It looks like @devansh-299 is an active committer in this project. I'm sure he will review and get back to you when he can.

If there's not enough active committers on this project, then the "right" thing to do in open source could be for the existing committers to invite new people who recently contributed quality to become additional committers... would this potentially interest you? You could write to the [email protected] mailing list to discuss that, if taking on this responsability interests you.

Sure

deepak-prajapatii avatar Jan 20 '21 10:01 deepak-prajapatii

@devansh-299 Please review my PR.

deepak-prajapatii avatar Jan 20 '21 10:01 deepak-prajapatii

Please do not tag me. I do not do any code review on this project. I only have access because of my involvement in L10n.

siebrand avatar Jan 20 '21 10:01 siebrand

Please do not tag me. I do not do any code review on this project. I only have access because of my involvement in L10n.

Okay, Next time I don't do

deepak-prajapatii avatar Jan 20 '21 11:01 deepak-prajapatii

@devansh-299 Please review my PR.

deepak-prajapatii avatar Jan 20 '21 14:01 deepak-prajapatii

@devansh-299 please review my PR,

deepak-prajapatii avatar Jan 22 '21 10:01 deepak-prajapatii

@deepak-prajapatii thank you for your contribution, this is a pretty big pull request and I shall review it as soon as possible and get back to you!

devansh-299 avatar Jan 27 '21 07:01 devansh-299

@deepak-prajapatii I think, In your branch have a code conflict . Are u still able to resolved it??

Prashant830 avatar Aug 11 '22 14:08 Prashant830