mobile-wallet icon indicating copy to clipboard operation
mobile-wallet copied to clipboard

Published 20 hours ago • verified publisher icon openMF

Adding extra-text to be send with QR code in showQrActivity

Open Harshad09 opened this issue 4 years ago • 5 comments
trafficstars

Issue Fix

Fixes #1131

Screenshots

WhatsApp Image 2021-01-07 at 12 49 46 AM (1) WhatsApp Image 2021-01-07 at 12 49 46 AM WhatsApp Image 2021-01-07 at 1 09 29 AM

Description

Added Intent.EXTRA_STRING to add a text that should be sent along with the QR code when we share the code to different apps using the android sharesheet.

  • [x] Apply the AndroidStyle.xml style template to your code in Android Studio.

  • [x] Run the unit tests with ./gradlew check to make sure you didn't break anything

  • [x] If you have multiple commits please combine them into one commit by squashing them.

Harshad09 avatar Jan 06 '21 19:01 Harshad09

@devansh-299 @s-ayush2903 Can you Please Review my PR

Harshad09 avatar Jan 09 '21 18:01 Harshad09

@s-ayush2903 Changed Mifos Pay to MifosPay

Harshad09 avatar Jan 09 '21 21:01 Harshad09

LGTM

s-ayush2903 avatar Jan 10 '21 00:01 s-ayush2903

@Harshad09 I think, In your branch have a code conflict . Are u still able to resolved it??

Prashant830 avatar Aug 11 '22 14:08 Prashant830

@Harshad09 I think you are not able to solve this conflict code at this time. So now I am going to create new pr for this issue.

Prashant830 avatar Aug 20 '22 15:08 Prashant830