mifos-mobile icon indicating copy to clipboard operation
mifos-mobile copied to clipboard

Snackbar pops on the FAB on deleting Beneficiary

Open miPlodder opened this issue 7 years ago • 4 comments
trafficstars

Summary:

Snackbar pops on the FAB on deleting Beneficiary

Steps to reproduce:

Beneficiary > Click on any Beneficiary or create new Beneficiary > Delete it from menu

Create new Beneficiary using details,

Account Number = 000000001 Office Number = Head Office

Rest information can be anything.

Expected behaviour:

FAB should animate upwards so that it doesn't get covered by Snackbar

Observed behaviour:

Instead, FAB doesn't animate.

Device and Android version:

Xiaomi, Marshmallow

Screenshots:

1 2

miPlodder avatar Nov 11 '18 07:11 miPlodder

@miPlodder I looked into the issue, and tried solving it. When the details fragment is destroyed upon deletion, the Snackbar is called and shown on the beneficiaries list page and hence this result, how could we get the view/fab object passed in the Snackbar if its not called from the list fragment.

nikhil-sachdeva avatar Dec 19 '18 13:12 nikhil-sachdeva

I would like to work on the issue if its still open?

rahul-jha98 avatar Jan 12 '19 03:01 rahul-jha98

@miPlodder Could I start working on the issue?

rahul-jha98 avatar Jan 13 '19 13:01 rahul-jha98

@nikhil-sachdeva and @rahul-jha98, there is already a PR for this issue, there is no point in making multiple PRs for a single issue.

luckyman20 avatar Jan 14 '19 10:01 luckyman20