mifos-mobile icon indicating copy to clipboard operation
mifos-mobile copied to clipboard

Fix Syntax Errors and Improve Unit Test Coverage

Open NiranjanNlc opened this issue 1 year ago • 4 comments

Fixes #2527

In this pull request, I address the syntax errors present in some of unit test files and improve the est coverage of the Android project .

  • [x] Apply the AndroidStyle.xml style template to your code in Android Studio.

  • [x] Run the unit tests with ./gradlew check to make sure you didn't break anything

  • [x] If you have multiple commits please combine them into one commit by squashing them.

NiranjanNlc avatar Mar 15 '24 04:03 NiranjanNlc

Hi @PratyushSingh07 and @therajanmaurya , Please just review this PR. since, i need to rewrite some of the approach , i just want to validate from you people that every thing is upto par .

Under approval of yours , i will apply these in other classes too . Thanks

NiranjanNlc avatar Mar 15 '24 04:03 NiranjanNlc

I believe you should probably use turbine to write unit tests as we are using kotlin flows

PratyushSingh07 avatar Mar 15 '24 04:03 PratyushSingh07

I believe you should probably use turbine to write unit tests as we are using kotlin flows

Thanks @PratyushSingh07 for suggestion.

NiranjanNlc avatar Mar 15 '24 04:03 NiranjanNlc

hey @PratyushSingh07 , I have used the turbine for testing flow .

Any feedback from your side ??

NiranjanNlc avatar Mar 15 '24 10:03 NiranjanNlc

I can see you have deleted so many ViewModel unit test why?

therajanmaurya avatar Mar 17 '24 13:03 therajanmaurya

I can see you have deleted so many ViewModel unit test why?

I just want to make sure the approach i followed now is upto par . I will add them if you validate this approach . Shall i go with these approach now ? You can merge PR after i added all of them . Thanks .

NiranjanNlc avatar Mar 17 '24 14:03 NiranjanNlc

I can see you have deleted so many ViewModel unit test why?

hey @therajanmaurya , I have added all of the test files for now . and all of the test are passed . Please get it reviewed now thanks

NiranjanNlc avatar Mar 20 '24 00:03 NiranjanNlc