mifos-mobile icon indicating copy to clipboard operation
mifos-mobile copied to clipboard

Published 20 hours ago • verified publisher icon openMF

fix #2486 : updated home activity onResume logic to solve the profile photo bug

Open NiranjanNlc opened this issue 1 year ago • 4 comments
trafficstars

Fixes #2486

Profile photo clearly visible while changing between dark and light mode .

https://github.com/openMF/mifos-mobile/assets/25600880/fa33702c-d76a-483f-9982-701311523a2a

Please make sure these boxes are checked before submitting your pull request - thanks!

  • [x] Apply the AndroidStyle.xml style template to your code in Android Studio.

  • [x] Run the unit tests with ./gradlew check to make sure you didn't break anything

  • [x] If you have multiple commits please combine them into one commit by squashing them.

NiranjanNlc avatar Jan 26 '24 12:01 NiranjanNlc

you are changing system theme . Does it work after changing the theme from inside of the app ?

PratyushSingh07 avatar Jan 26 '24 13:01 PratyushSingh07

you are changing system theme . Does it work after changing the theme from inside of the app ?

Yeah , i have updated the screen recorder video of description and added the commit .

@PratyushSingh07 Please review and provide some suggestion.

NiranjanNlc avatar Jan 26 '24 14:01 NiranjanNlc

There is a similar bug in Profile photo of Navigation Drawer. Can you check that also @NiranjanNlc

AvneetSingh2001 avatar Feb 04 '24 21:02 AvneetSingh2001

There is a similar bug in Profile photo of Navigation Drawer. Can you check that also @NiranjanNlc

yeah i had found it , since this pull request solved for both cases , so did not think of raising next issues . Please conform from the screen-cast I attached in the pull request description.

NiranjanNlc avatar Feb 05 '24 04:02 NiranjanNlc