fix: Improve clarity and correctness in showFilterDialog

[Thanush66]

Fixes #2457

Please Add Screenshots If there are any UI changes.

https://github.com/openMF/mifos-mobile/assets/136256522/53aa2db7-fe6f-4e43-baf5-0e65cd43be0c

Please make sure these boxes are checked before submitting your pull request - thanks!

• [x] Apply the AndroidStyle.xml style template to your code in Android Studio.

• [x] Run the unit tests with ./gradlew check to make sure you didn't break anything

• [x] If you have multiple commits please combine them into one commit by squashing them.

[ghost]

@PratyushSingh07 review this....Also there was an another issue in this should i make another issue or solve in this

[PratyushSingh07]

@PratyushSingh07 review this....Also there was an another issue in this should i make another issue or solve in this

What's the other issue?

[ghost]

@PratyushSingh07 The contact us is going to top if there are no transactions it should be at the bottom

[PratyushSingh07]

@PratyushSingh07 The contact us is going to top if there are no transactions it should be at the bottom

Well I personally don't think this is an issue. In my opinion it would have looked odd if it was at the bottom. Why don't you try to change this behaviour and then we can compare which version looks better. Implement it in this PR itself and incase it doesn't look good you can always reset back to the previous commit

[ghost]

@PratyushSingh07 Okay!

[ghost]

[PratyushSingh07]

Hmm ... Your call @Thanush66 I like both of them 😅

[ghost]

@PratyushSingh07 ig the second looks cleaner , Its just my opinion..!

[PratyushSingh07]

Alright let's go with this

[ghost]

@PratyushSingh07 Done with changes.....Any more changes...?