mifos-mobile icon indicating copy to clipboard operation
mifos-mobile copied to clipboard

Fixed Feat: Implement Shimmer while user details are being loaded

Open kmanikanta335 opened this issue 2 years ago • 10 comments
trafficstars

Fixes #2412

Screenshots of UI changes.

https://github.com/openMF/mifos-mobile/assets/118070186/747c140f-e653-451d-ad05-4a485c8f5d9c

https://github.com/openMF/mifos-mobile/assets/118070186/36a2e396-25ed-4254-b548-64bd584c8b9d

Please make sure these boxes are checked before submitting your pull request - thanks!

  • ✅ Apply the AndroidStyle.xml style template to your code in Android Studio.

  • ✅ Run the unit tests with ./gradlew check to make sure you didn't break anything

  • ✅ If you have multiple commits please combine them into one commit by squashing them.

kmanikanta335 avatar Nov 19 '23 10:11 kmanikanta335

@PratyushSingh07 pls review it

kmanikanta335 avatar Nov 19 '23 10:11 kmanikanta335

make sure to change the commit message @kmanikanta335

PratyushSingh07 avatar Nov 22 '23 16:11 PratyushSingh07

@PratyushSingh07 what should I change it to

kmanikanta335 avatar Nov 22 '23 16:11 kmanikanta335

@PratyushSingh07 what should I change it to

just follow the guidelines

PratyushSingh07 avatar Nov 22 '23 17:11 PratyushSingh07

@PratyushSingh07 when will it gets merged

kmanikanta335 avatar Nov 26 '23 04:11 kmanikanta335

@PratyushSingh07 when will it gets merged

You still haven't followed the commit guidelines. It will be merged only after the admins approval

PratyushSingh07 avatar Nov 26 '23 09:11 PratyushSingh07

@PratyushSingh07 i hope now its fine

kmanikanta335 avatar Nov 26 '23 12:11 kmanikanta335

Please resolve the conflicts.

therajanmaurya avatar Dec 28 '23 16:12 therajanmaurya

@therajanmaurya i hope now it fine

kmanikanta335 avatar Jan 02 '24 15:01 kmanikanta335

@kmanikanta335 squash your commits and make sure that your final commit follow contribution guidelines . I am again converting it to draft

PratyushSingh07 avatar Jan 02 '24 19:01 PratyushSingh07