mifos-mobile icon indicating copy to clipboard operation
mifos-mobile copied to clipboard

Feat: Implement Shimmer while user details are being loaded

Open PratyushSingh07 opened this issue 2 years ago • 22 comments

Summary:

I would love to implement a shimmer that is displayed while the details are being loaded.

Steps to reproduce:

When you open the mobile application then the layout showing the user image and name are empty at first because they are being loaded. At such a point a shimmer effect would be good to have.

PratyushSingh07 avatar Oct 19 '23 06:10 PratyushSingh07

@PratyushSingh07 I want to work on this issue, please assign me.

ShivanshKumar4265 avatar Oct 27 '23 17:10 ShivanshKumar4265

Sure , go ahead

PratyushSingh07 avatar Oct 27 '23 19:10 PratyushSingh07

@CodeXstalker Are you still working on it...?if not i can work on this

ghost avatar Nov 02 '23 15:11 ghost

@Thanush66 I am working on it

ShivanshKumar4265 avatar Nov 02 '23 17:11 ShivanshKumar4265

can i work on this issue @PratyushSingh07 ?

kmanikanta335 avatar Nov 10 '23 13:11 kmanikanta335

@CodeXstalker are you still working on it ? please give us an update about your progress. If there hasnt been any progress then I would like to re-assign it to someone else

Also @kmanikanta335 , if @CodeXstalker gives up on this issue then it will be assigned to @Thanush66 since he had asked earlier. You will be assigned this issue only if these 2 no longer work on it

PratyushSingh07 avatar Nov 10 '23 13:11 PratyushSingh07

@PratyushSingh07 In that case please assign me any other good first issues, I would like to contribute

kmanikanta335 avatar Nov 10 '23 13:11 kmanikanta335

@PratyushSingh07 you can assign to others.

ShivanshKumar4265 avatar Nov 11 '23 02:11 ShivanshKumar4265

@Thanush66 , do you want to work on it ? if not then I will pass this to @kmanikanta335

PratyushSingh07 avatar Nov 11 '23 06:11 PratyushSingh07

@PratyushSingh07 Yeah I will be working on it..

ghost avatar Nov 11 '23 09:11 ghost

hey @PratyushSingh07 unfortunately I have completed my work on this issue can I make a pullrequest

https://github.com/openMF/mifos-mobile/assets/118070186/d2776712-a4fc-4682-bc33-890f3f27ba39

kmanikanta335 avatar Nov 11 '23 11:11 kmanikanta335

No @kmanikanta335, you cannot make a PR as this isn't assigned to you. Also this isn't where I was expecting the shimmer. I wanted that in the home screen when the user image and text is being loaded. So your PR won't be able to solve the exact issue

PratyushSingh07 avatar Nov 11 '23 11:11 PratyushSingh07

@Thanush66 yeah can you solve this issue ? if yes how many days ? I can solve this in one day please leave this to me , I really want to become an contributor since I am new and you already an contributor

kmanikanta335 avatar Nov 11 '23 18:11 kmanikanta335

Hi, I have worked on this issue and want your feedback. I know I haven't been assigned to the case, but I worked on this issue to gain insight into how the app functions.

I have set the network type to UMTS so that the shimmer effect is properly visible while the data is being fetched. (u can skip to 30 sec after a few seconds into the video)

https://github.com/openMF/mifos-mobile/assets/85576130/745e8ae4-9145-4c55-a49b-10cecb305e58

This is how it would look like in Full network:

https://github.com/openMF/mifos-mobile/assets/85576130/91aeee26-a2f8-4a7a-8f67-2dc4a925eb4e

@PratyushSingh07, please share your review on this

ps: I don't expect this to be merged. I only worked on the issue to have a better understanding of the app since I'm very new to open source.

jarvision-git avatar Nov 13 '23 10:11 jarvision-git

Awesome job @jarvision-git , the effect being showcased in full network is what I actually want.

PratyushSingh07 avatar Nov 13 '23 11:11 PratyushSingh07

@Thanush66 yeah are u still working on it ?

kmanikanta335 avatar Nov 17 '23 07:11 kmanikanta335

@PratyushSingh07 Can you re-assign it.?

ghost avatar Nov 18 '23 05:11 ghost

You Can work on it @kmanikanta335

PratyushSingh07 avatar Nov 18 '23 06:11 PratyushSingh07

@PratyushSingh07 ok I am on it

kmanikanta335 avatar Nov 18 '23 07:11 kmanikanta335

is this fixed.

KUSHAL-RAJ-PAREEK avatar Jan 16 '24 04:01 KUSHAL-RAJ-PAREEK

is this issue closed or still open?

r1shhh1 avatar Feb 22 '24 04:02 r1shhh1