mifos-mobile icon indicating copy to clipboard operation
mifos-mobile copied to clipboard

Fixes #1717: Beneficiary creation and update fixed

Open PatelVatsalB21 opened this issue 4 years ago • 4 comments

Fixes #1717

https://user-images.githubusercontent.com/70195106/107856569-fb722b80-6e4e-11eb-9c47-0f86b46aadc7.mp4

  • [x] Apply the AndroidStyle.xml style template to your code in Android Studio.

  • [x] Run the unit tests with ./gradlew check to make sure you didn't break anything

  • [x] If you have multiple commits please combine them into one commit by squashing them.

PatelVatsalB21 avatar Feb 13 '21 18:02 PatelVatsalB21

@PatelVatsalB21 As mentioned in one of the previous or, this issue must be handled in the backend so this issue needs to be raised in the backend repo. The amount can be a floating number.

divyank00 avatar Feb 16 '21 15:02 divyank00

@divyank00 yes you are right but here backend issue are long awaited, one for editing profile is there but no endpoint for editing profile is available, so during GSOC period mentor and maintainers would be active we can ask at that time. Or do you say to raise error in fineract ?

PatelVatsalB21 avatar Feb 17 '21 05:02 PatelVatsalB21

@divyank00 @PatelVatsalB21 I ran into this issue, and was about to create an issue here. If I understand correctly, the server never accepted float before, so the app should send long until the server is changed. It's currently not possible to send 1000 or 1000.00 using the app so the feature is totally broken. IMO this PR should be merged, and an issue created on the fineract JIRA to request the new feature if desirable (accepting floats)

Create Beneficiary validation: https://github.com/apache/fineract/blob/develop/fineract-provider/src/main/java/org/apache/fineract/portfolio/self/account/data/SelfBeneficiariesTPTDataValidator.java#L90-L91 Update Beneficiary validation: https://github.com/apache/fineract/blob/develop/fineract-provider/src/main/java/org/apache/fineract/portfolio/self/account/data/SelfBeneficiariesTPTDataValidator.java#L126-L127

mysql> explain m_selfservice_beneficiaries_tpt;
+----------------+-------------+------+-----+---------+----------------+
| Field          | Type        | Null | Key | Default | Extra          |
+----------------+-------------+------+-----+---------+----------------+
   ... trimmed
| transfer_limit | bigint(20)  | YES  |     | 0       |                |
   ... trimmed
+----------------+-------------+------+-----+---------+----------------+

I tried tracking down the functional spec for this, but unfortunately it doesn't set out long/float - https://cwiki.apache.org/confluence/display/FINERACT/Customer+Self-Service+Phase+2

afk11 avatar Nov 08 '21 17:11 afk11

For consideration - I have an alternative which uses long here, in case that's preferable https://github.com/openMF/mifos-mobile/pull/1815

afk11 avatar Nov 09 '21 16:11 afk11