refactor #1625: redesigned home ui as per new design

[yashraj-01]

trafficstars

Fixes #1625

Old UI:

New UI:

Note: The new ui can be accessed by clicking Surveys button on the Home Screen.

• [x] Apply the AndroidStyle.xml style template to your code in Android Studio.

• [x] Run the unit tests with ./gradlew check to make sure you didn't break anything

• [x] If you have multiple commits please combine them into one commit by squashing them.

[yashraj-01]

@miPlodder @garvit984 please review.

[rutvik-panchal]

Already there is one PR related to redesigning of the home screen #1541

[garvit984]

@rutvik-panchal But the person who has made that PR is currently unavailable and it has some conflicts associated with it. So, we cannot move forward with that PR.

[garvit984]

@yashraj-iitr The icon for no recent transaction found seems a bit odd. Can you suggest something else?

[yashraj-01]

* One suggestion after looking at this PR, can you take a deeper look at the existing code once, and then continue. It will be helpful for your understanding of legacy code. since, it's a rewrap up of UI, not a bug fix.

* I don't see `Nav Drawer`, `Survey`, `Beneficiary` in GIF. aren't they added as part of this PR?

thank you for your suggestion @miPlodder . I will do the same.

There is no Nav Drawer in the new ui. It is replaced with Bottom Navigation. As for Survey there is no activity/fragment present in the current code. So, I couldn't redesign it.

Also, I have not redesigned other screens such as Accounts Transfer etc. in this PR as I thought redesigning all the screens in one PR would contain too many changes and it might be difficult to review. This PR contains only the BottomNavigation and the home screen.

[yashraj-01]

@yashraj-iitr The icon for no recent transaction found seems a bit odd. Can you suggest something else?

yes. I thought the same but since I didnot alter the RecentTransactionsFragment, I didnot change it. If you want I can change it to a proper error icon or some other icon that you might suggest.

[garvit984]

@yashraj-iitr The icon for no recent transaction found seems a bit odd. Can you suggest something else?

yes. I thought the same but since I didnot alter the RecentTransactionsFragment, I didnot change it. If you want I can change it to a proper error icon or some other icon that you might suggest.

@yashraj-iitr Yes you can make an issue and a PR for it.

[yashraj-01]

@yashraj-iitr The icon for no recent transaction found seems a bit odd. Can you suggest something else?

yes. I thought the same but since I didnot alter the RecentTransactionsFragment, I didnot change it. If you want I can change it to a proper error icon or some other icon that you might suggest.

@yashraj-iitr Yes you can make an issue and a PR for it.

@garvit984 PR #1629 fixes this issue. please review it.

[miPlodder]

As for Survey there is no activity/fragment present in the current code. So, I couldn't redesign it.

Still, let's add place holder for them.

Also, I have not redesigned other screens such as Accounts Transfer etc. in this PR as I thought redesigning all the screens in one PR would contain too many changes and it might be difficult to review. This PR contains only the BottomNavigation and the home screen.

• Let's use ui-redesign in this branch for redesign purposes, instead of directly targeting development. When the redesigning of the app is completed, we can merge ui-redesign it into development.
• Target this PR to ui-design branch.
• Create a PR for development branch changing the Branch policy that all redesign work will be done on ui-design branch. So, other contributors some to know about it too.
• Even update about this in the Gitter group too, so that it doesn't confuse others

[yashraj-01]

* Let's use `ui-redesign` in this branch for redesign purposes, instead of directly targeting `development`. When the redesigning of the app is completed, we can merge `ui-redesign` it into development.

* Target this PR to `ui-design` branch.

* Create a PR for `development branch` changing the Branch policy that all redesign work will be done on `ui-design` branch. So, other contributors some to know about it too.

@miPlodder I have targeted this PR to ui-redesign branch and I also made a PR( #1660 ) to update the branch policy in the readme.md.

@miPlodder @garvit984 Can you please guide me further? I mean should I implement all ui redesigns in this PR only or should I make different PRs targeted to ui-redesign branch as I keep implementing ui redesigns of different screens?

[garvit984]

@yashraj-iitr You can implement different screens in different PRs. This will make it easy to track different features.

[garvit984]

@yashraj-iitr Are you still working on it?