community-app
community-app copied to clipboard
Create Client doesn't giving error on submit without filling form #3069
Description
Describe the changes made and why they were made instead of how they were made.
Related issues and discussion
#{Issue Number}
Screenshots, if any
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
-
[ ] Validate the JS and HTML files with
grunt validate
to detect errors and potential problems in JavaScript code. -
[ ] Run the tests by opening
test/SpecRunner.html
in the browser to make sure you didn't break anything. -
[ ] If you have multiple commits please combine them into one commit by squashing them.
-
[ ] Read and understood the contribution guidelines at
community-app/Contributing.md
.
@bharathcgowda Not properly addressed. Still I'm able to create a client without specifying the Legal Form. Not giving an error. Changes imply that the field has been marked as required. But haven't addressed the complete problem
@habile-technologies can you please verify the same.
@BLasan Could you please refer the below branch , i added the validation in back end also .Branch name is issue#3069
https://github.com/apache/fineract/compare/develop...habile-technologies:issue%233069
@BLasan is it good to merge this PR?
@BLasan is it good to merge this PR?
Works fine. But please check on this comment sir - https://github.com/apache/fineract/pull/1725#issuecomment-840916762