community-app icon indicating copy to clipboard operation
community-app copied to clipboard

Bug: Redundant code for incentives in Create FD account controller

Open abhi40308 opened this issue 4 years ago • 1 comments

Description

The code for "incentives" in CreateFixedDepositAccountController.js is taken from CreateFixedDepositProductController.js which has "add" and "remove" incentive option, which is not needed while creating FD account.

Steps to Reproduce

Go to https://staging.mifos.io . Create a new FD account. See "incentives" column in interest rate chart part. The code for this is redundant. (more precisely, functions addNewRow and removeRow are not required in the controller in var IncentiveCtrl).

Settings

  • Mifos X version:
  • Browser used:
  • OS:

Screenshots

Screen : Create FD Account : Screenshot 2020-03-21 at 6 52 22 PM

Screen : Create FD product : Screenshot 2020-03-21 at 6 51 45 PM

abhi40308 avatar Mar 21 '20 13:03 abhi40308

hi @abhi40308 if this issue still open i want to work on this can you please guide me

raghu0812199 avatar Jan 06 '21 18:01 raghu0812199