community-app icon indicating copy to clipboard operation
community-app copied to clipboard

Fixed #1715 - Added Functionality to edit role name and description

Open MYKatz opened this issue 8 years ago • 7 comments

Added functionality allowing admins to edit role names and descriptions. Pressing the edit icons opens up a modal w/ textarea. Once confirmed, changes to names and descriptions happen in the scope and backend (thru API). Screenshots:

screenshot 5 screenshot 7 screenshot 8

MYKatz avatar Dec 09 '17 20:12 MYKatz

Thanks for the PR, It will be reviewed Shortly!

This message was posted by GitMate.io with timestamp signature Thanks for the PR, It will be reviewed Shortly!:1eNm2r:5ZdcjChFTlijArms4bYV_TxPOP4

mbj36 avatar Dec 09 '17 20:12 mbj36

The Travis CI build failed due to the PUT method I added in the roleResource. I'm unsure of how to remedy this while retaining the functionality I added. A little assistance would be great, thanks!

MYKatz avatar Dec 09 '17 22:12 MYKatz

@gkrishnan724 Updated 👍

MYKatz avatar Dec 10 '17 09:12 MYKatz

@gkrishnan724 I made the changes you requested. Unfortunately it seems that TravisCi still rejects this. Looking at the logs, I think this is because the role resource is hard-coded into the unit test.

MYKatz avatar Dec 11 '17 05:12 MYKatz

Thanks! changes look good

gkrishnan724 avatar Dec 11 '17 05:12 gkrishnan724

@MYKatz please look into this, and try to resolve test issues we can merge this

shrunk3 avatar Mar 05 '21 20:03 shrunk3

@MYKatz please look into this, and try to resolve test issues we can merge this

On it. Will be done by mid-April (2024) at the latest.

MYKatz avatar Mar 05 '21 21:03 MYKatz