refactor(feature:client): migrate to CMP
Fixes - Jira-#417
The screen recording shows:
-
It shows navigation to the Client List screen from the Home page by clicking the Clients icon in the bottom bar, and then going back.
-
It shows that clicking the Floating Action Button (FAB) navigates to the Create New Client form, and then back.
-
From the Client List screen, one can also navigate to the Create New Client screen using the FAB.
-
In the Create New Client form:
-
An image is uploaded using the camera.
-
The image is removed.
-
Another image is added from the gallery.
-
-
The client creation form is then submitted after filling in the required details.
I’d like to thank @revanthkumarJ for his help with the document picker discussion, as well as for the support in figuring out how to view individual screens by bypassing the actual navigation during testing.
-
[X] Run the static analysis check
./gradlew checkorci-prepush.shto make sure you didn't break anything -
[X] If you have multiple commits please combine them into one commit by squashing them.
@biplab1 is it ready to get reviewed? you facing any issues?
@biplab1 could you also please attach a video showing how the screen behaves when no permission has been granted?!!
@biplab1 could you also please attach a video showing how the screen behaves when no permission has been granted?!!
I’ve added the video in the PR description showing the screen behavior without permission. I was planning to include it even before you mentioned—glad you brought it up!
@niyajali Although this PR has received two approvals and all reviewer comments have been addressed, there are still some bugs in the individual screens of sub-features under feature/client that need to be fixed. It appears these bugs were already present and not introduced during the migration.
We can either resolve them within this PR or merge it as is and create separate Jira tickets for each sub-feature to address the issues individually.
Let me know how you'd like me to proceed.
@biplab1 why there's empty space below of the top bar?
@niyajali I'm not sure which screen you're referring to. If you're talking about the Client Details screen, there is a space allocated for the client image. The image is intended to be loaded using ImageLoaderUtils, but the relevant code is currently commented out. This is because ImageLoaderUtils hasn't been properly injected in the NetworkModule, which is causing an error.