android-client icon indicating copy to clipboard operation
android-client copied to clipboard

Refactor: Migrate CreateNewCenterFragment to Jetpack Compose

Open ashutosh-kumar-kushwaha opened this issue 10 months ago • 4 comments

Fixes #2077

Please Add Screenshots If there are any UI changes.

Screenshot_20240402-214705_MifosXDroid

Screenshot_20240402-214723_MifosXDroid

Please make sure these boxes are checked before submitting your pull request - thanks!

  • [x] Apply the MifosStyle.xml style template to your code in Android Studio.

  • [x] Run the unit tests with ./gradlew check to make sure you didn't break anything

  • [x] If you have multiple commits please combine them into one commit by squashing them.

ashutosh-kumar-kushwaha avatar Apr 02 '24 16:04 ashutosh-kumar-kushwaha

I tested the functionality, It is not same as it was implemented in XML and also search functionality is broken. I always get no result.

therajanmaurya avatar Apr 07 '24 22:04 therajanmaurya

I tested the functionality, It is not same as it was implemented in XML and also search functionality is broken. I always get no result.

The Create Center functionality is broken in XML as well. Always gives HTTP 400 or 500.

The progress bar was implemented inside the screen in XML, whereas I implemented it within a Dialog in Compose. I will fix that. Apart from this, I did not see any other differences.

ashutosh-kumar-kushwaha avatar Apr 07 '24 22:04 ashutosh-kumar-kushwaha

Can you please upload the before and after videos? I want to include this implementation in our codebase but we must maintain the code quality.

Also check why always API gives No search found but in development branch it does return on searc

therajanmaurya avatar Apr 07 '24 23:04 therajanmaurya

Can you please upload the before and after videos? I want to include this implementation in our codebase but we must maintain the code quality.

Before -

https://github.com/openMF/android-client/assets/109234707/5d62caa4-a78b-4392-9d87-8d477077764f

After -

https://github.com/openMF/android-client/assets/109234707/75d392ba-719a-4cc7-9fdc-b8b6d801b66f

Also check why always API gives No search found but in development branch it does return on searc

The SearchScreen one is a different PR. This PR is for CreateNewCenterFragment.

ashutosh-kumar-kushwaha avatar Apr 08 '24 00:04 ashutosh-kumar-kushwaha