android-client icon indicating copy to clipboard operation
android-client copied to clipboard

Multiple empty extension functions declared and used, needs to be replaced.

Open ashwinkey04 opened this issue 4 years ago • 3 comments

Summary:

Multiple empty extension functions are used for overcoming lint errors, which are potential sources of crashes. Some of them are linked here: [1] [2] [3]

Observed behavior: Empty extension functions with the below definition occur multiple times.

private fun <E> List<E>.add() {

}

Expected behavior:

Adding these empty extension functions will only overcome the lint errors, but keeping it blank will lead to crashes upon its usages. The variables on which add() function is used need to be changed from immutable data types to mutable ones. Then the built-in addAll() function should be used on those mutable data.

Example: Usage in mifos-mobile.

ashwinkey04 avatar Dec 02 '21 05:12 ashwinkey04

hello, wanted to contribute to this issue..!! can you clarify more on the issue since I am beginner in contribution.

avivijay19 avatar Jan 18 '22 11:01 avivijay19

Hey , I am a Kotlin developer and I would be happy to work on this issue. Will be gad to contribute !

Pramath02 avatar Dec 07 '23 18:12 Pramath02

@avivijay19 hey are you still working on the issue or its fixed.

SOUMEN-PAL avatar Mar 13 '24 05:03 SOUMEN-PAL