android-client
android-client copied to clipboard
openMF
Fixes #1570 : (Fixed) Swipe Refresh Layout is refreshing when pressed back button(twice) while creating groups
Fixes #1570 : ✓ Apply the MifosStyle.xml style template to your code in Android Studio. ✓ Run the unit tests with ./gradlew check to make sure you didn't break anything
✓ If you have multiple commits please combine them into one commit by squashing them.
I would request the project mentors to please review and merge my pull request. If there's any issue, please drop a comment below.
Recording after Fix:
https://user-images.githubusercontent.com/47531297/110204632-13f7c380-7e9a-11eb-8880-efc02d5d123a.mp4
why have you closed the PR @sreyans01 ?
Sir, I was unable to figure out why is build test getting failed in github, thatswhy I closed the PR. It would be very nice if you could guide me out to make the tests pass in the build.
I closed it because the build was failing. Now, I have reopened it and linked it to the correct issue #1570 , and all the checks have been passed.
On Sat, Mar 6, 2021 at 8:20 PM danishjamal104 [email protected] wrote:
why have you closed the PR @sreyans01 https://github.com/sreyans01 ?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/openMF/android-client/pull/1802#issuecomment-791965763, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALKUKIPB37ARYR4ER5XXUB3TCI6LDANCNFSM4YWTYOWQ .
why have you closed the PR @sreyans01 ?
Sir, I was unable to figure out why is build test getting failed in github, thatswhy I closed the PR. It would be very nice if you could guide me out to make the tests pass in the build.
can you help me how you fixed that GitHub build because I am also facing the same issue, Thank You
@danishjamal104 is #1571 not relevant. If yes then this is repetitive pr. Isn't it?
why have you closed the PR @sreyans01 ?
Sir, I was unable to figure out why is build test getting failed in github, thatswhy I closed the PR. It would be very nice if you could guide me out to make the tests pass in the build.
can you help me how you fixed that GitHub build because I am also facing the same issue, Thank You
I just did another unit test and made a new pull request.
@danishjamal104 is #1571 not relevant. If yes then this is repetitive pr. Isn't it?
Its a repetitive pr of #1801 which was made and closed by me due to failed build tests. Now it got passed, so I created this one and closed the previous one.
@sreyans01 You can change code inside same pr by force pushing local commit instead of making new branch every time. It might help you manage prs ahead.
Yes, I will do that from next time.