android-client icon indicating copy to clipboard operation
android-client copied to clipboard

Published 20 hours ago • verified publisher icon openMF

fixes #1572 fixed back action on Clients/Centers/Groups section

Open danishjamal104 opened this issue 4 years ago • 3 comments

Fixes #1572

Changes Pressing back on the Clients/Groups/Centers section redirect back to Dashboard instead of showing the toast and exiting the app

Screenshot 2020-11-19 at 5 10 13 PM

Please make sure these boxes are checked before submitting your pull request - thanks!

  • [x] Apply the MifosStyle.xml style template to your code in Android Studio.

  • [x] Run the unit tests with ./gradlew check to make sure you didn't break anything

  • [x] If you have multiple commits please combine them into one commit by squashing them.

danishjamal104 avatar Nov 25 '20 09:11 danishjamal104

@robustTechie please review the changes. Thanks!

danishjamal104 avatar Nov 25 '20 10:11 danishjamal104

@iamsh4shank keep this PR on hold it might have already been fixed since their are major changes in DashboardActivity.java, this PR make changes to the deleted part of the code so its better we put this on hold and move with rest of the PRs. WE can surly test this later and then merge. Thanks :)

danishjamal104 avatar Jul 16 '21 05:07 danishjamal104

@iamsh4shank keep this PR on hold it might have already been fixed since their are major changes in DashboardActivity.java, this PR make changes to the deleted part of the code so its better we put this on hold and move with rest of the PRs. WE can surly test this later and then merge. Thanks :)

yep that makes sense, let's first test the app with existing change and merge it accordingly :)

iamsh4shank avatar Jul 17 '21 15:07 iamsh4shank

We are closing this PR as it causes a branch conflict since the Java file has now been migrated to kotlin

Aditya-gupta99 avatar Jun 20 '23 14:06 Aditya-gupta99