Fineract-CN-mobile icon indicating copy to clipboard operation
Fineract-CN-mobile copied to clipboard

Published 20 hours ago • verified publisher icon openMF

feat:added credentials verification check

Open ivary43 opened this issue 6 years ago • 3 comments

Please make sure these boxes are checked before submitting your pull request - thanks!

Fixes #230

  • [x] Apply the AndroidStyle.xml style template to your code in Android Studio.

  • [x] Run the unit tests with ./gradlew check to make sure you didn't break anything

  • [x] If you have multiple commits please combine them into one commit by squashing them.

ivary43 avatar Apr 03 '18 19:04 ivary43

@ivary43 Please refrain from duplicating the issue. A similar issue #227 was already created and I had started working on it by adding username checks.

AkshGautam avatar Apr 03 '18 19:04 AkshGautam

@AkshGautam I think this is not duplicate issue this is not only related to username length I added trimming, spaces check and password length check.I will remove that line containing username length you can add that.

ivary43 avatar Apr 03 '18 20:04 ivary43

@ivary43 its fine, you can add that line too. It's not wise to make another PR by adding all the functions again and then resolve merge conflicts.You can add that to this PR itself. My bad that I did not explicitly explain the entire issue and started working on it.

AkshGautam avatar Apr 03 '18 20:04 AkshGautam