Fineract-CN-mobile icon indicating copy to clipboard operation
Fineract-CN-mobile copied to clipboard

feat:added ABI filters to reduce APK size

Open ivary43 opened this issue 6 years ago • 5 comments

Please make sure these boxes are checked before submitting your pull request - thanks!

Fixes #214

  • [x] Apply the AndroidStyle.xml style template to your code in Android Studio.

  • [x] Run the unit tests with ./gradlew check to make sure you didn't break anything

  • [x] If you have multiple commits please combine them into one commit by squashing them.

ivary43 avatar Apr 02 '18 14:04 ivary43

@therajanmaurya please review.

ivary43 avatar Apr 02 '18 16:04 ivary43

@ivary43 I guess currently this application does not contain any Native Library, so adding ABI Filters wouldn't decrease the APK size.

miPlodder avatar May 14 '18 19:05 miPlodder

@miPlodder I didn't get you why it wouldn't, this is ABI split for various CPU architecture.

ivary43 avatar May 14 '18 19:05 ivary43

@ivary43 ABI Split will create different APKs for different Architecture. But what's the point of creating multiple APK's, if all of them are equivalent. We used it in other project (like https://github.com/openMF/mifos-mobile/tree/development/app/src/main/jniLibs) because we have a Native Encryption Library as dependency. In that case, it would make sense because creating 1 APK and having multiple Architecture dependency, although the device using that APK will have only 1 Architecture and will used that dependency only. Hence, other Native Libraries are increasing the APK size and splitting the APK on basis on Architecture will be beneficial, which is not true for this Project as of now since it doesn't contain any Native Dependency.

miPlodder avatar May 14 '18 20:05 miPlodder

Oh yeah sorry, I totally forgot there is no passcode feature so they don't have to encrypt the password and save it, I mistakenly assumed these are all present and didn't check for the .so files.

ivary43 avatar May 14 '18 20:05 ivary43