owt-client-javascript icon indicating copy to clipboard operation
owt-client-javascript copied to clipboard

WebRTC Stack in Firefox 110 changed, channel.js needs changes - suggesting FIX

Open schlypel opened this issue 2 years ago • 1 comments

In channel.js are 2 lines, that differentiate between encoding and parameter handling for firefox vs. other browsers.

The lines are: 312 & 339 https://github.com/open-webrtc-toolkit/owt-client-javascript/blob/main/src/sdk/conference/channel.js#L312 https://github.com/open-webrtc-toolkit/owt-client-javascript/blob/main/src/sdk/conference/channel.js#L339

This breaks functionality in Firefox 110 (update was released on Feb. 14 2023)

We fixed the issue by checking not only if it is Firefox via Utils.isFirefox() but also checking if the major version is < 110.

We have the major version in our app from some other source, owt client could use Utils.sysInfo().runtime.version.

The specific handling for Firefox seems to be not longer needed in this lines. For us it works again now.

Untested FIX: 312| if (Utils.isFirefox() && Utils.sysInfo().runtime.version.split('.')[0] < 110) {

schlypel avatar Feb 23 '23 14:02 schlypel

@schlypel bug with FireFox is confirmed. Your fix is also confirmed as working.

andreasunterhuber avatar Feb 24 '23 14:02 andreasunterhuber