owt-client-javascript icon indicating copy to clipboard operation
owt-client-javascript copied to clipboard

Published 20 hours ago • verified publisher icon open-webrtc-toolkit

Enable audio denoise for OWT using a Wasm port of RNNoise Library

Open arunetm opened this issue 5 years ago • 6 comments

This PR enables OWT to apply denoising to audio streams in the connection.

This is accomplished by porting the RNNoise NN based denoising library to WebAssembly and incorporating it to OWT audio stream processing. MediaStreams can be created with or without the denoising pipeline added.

PTAL

arunetm avatar Aug 15 '20 18:08 arunetm

The details of failed CI tests appears to to inaccessible. How to view the logs?

arunetm avatar Aug 15 '20 18:08 arunetm

@taste1981 please review. The update moves implementation to use AudioWorklets as discussed. The issue with mismatched sample buffer size between Audioworklet (128) and Rnnoise (>512) is resolved using a new ring buffer.

arunetm avatar Oct 19 '20 02:10 arunetm

@jianjunz please review this.

taste1981 avatar Oct 19 '20 06:10 taste1981

It looks good to me. @taste1981, please check if the audio worklet has any license issue or code scan issue. If no, please merge this PR, thanks.

jianjunz avatar Mar 01 '21 05:03 jianjunz

It looks good to me. @taste1981, please check if the audio worklet has any license issue or code scan issue. If no, please merge this PR, thanks.

Unless the source code includes a copyright section as required by https://github.com/xiph/rnnoise 's copyright text, We should not allow this to be merged.

taste1981 avatar Mar 01 '21 06:03 taste1981

Thanks for the review. I will edit the source to meet the copyright requirements and update this PR.

arunetm avatar Mar 01 '21 06:03 arunetm