owt-client-javascript icon indicating copy to clipboard operation
owt-client-javascript copied to clipboard

ConferenceClientConfiguration not exported

Open alex-bluetrain opened this issue 6 years ago • 2 comments

Owt.Conference.ConferenceClientConfiguration is not being exported there's no way to create an instance of it, it is undefined. I'm using the 2.4.x branch but it seems the same problem goes to master branch as well.

it's curious nobody's using tun/stun servers on the javascript client.

alex-bluetrain avatar Oct 10 '19 22:10 alex-bluetrain

to fix this, you have to make the following changes:

src/sdk/conference/export.js add the following line: export {ConferenceClientConfiguration} from './client.js';

src/sdk/conference/client.js add the following line, after class ConferenceClientConfiguration {...} block: exports.ConferenceClientConfiguration = ConferenceClientConfiguration;

that's it

alex-bluetrain avatar Oct 11 '19 08:10 alex-bluetrain

Thanks for reporting this issue. You may submit a PR to fix it. Before this issue is fixed, please create an object, and add ICE servers to its rtcConfiguration property. It should work as an instance of ConferenceClientConfiguration.

jianjunz avatar Oct 12 '19 04:10 jianjunz