custom-elements-manifest icon indicating copy to clipboard operation
custom-elements-manifest copied to clipboard

update included typescript version

Open KingOfTac opened this issue 2 years ago • 2 comments

Checklist

  • [x] Did you run the analyzer with the --dev flag to get more information?
  • [ ] Did you create a minimal reproduction in the playground?

Currently, it looks like the analyzer is using [email protected] internally. AST Explorer now uses [email protected] which has made developing plugins a bit difficult due to typescript internal interfaces changing across versions. An example of this is in the SyntaxKind enum. In AST Explorer a node kind of 237 is a VariableStatement and in the analyzer it is a WhileStatement.

KingOfTac avatar May 15 '23 18:05 KingOfTac

yeah you shouldnt really check for SyntaxKind like that I dont think, you should use the methods provided by TS, like ts.isStringLiteral etc

thepassle avatar May 15 '23 18:05 thepassle

yeah you shouldnt really check for SyntaxKind like that I dont think, you should use the methods provided by TS, like ts.isStringLiteral etc

Makes sense, thanks. One other thing I have run up against with the version bundled with the analyzer is that it looks like it doesn't associate jsDoc comments with variable declarations while newer versions of the language do.

KingOfTac avatar May 15 '23 18:05 KingOfTac

Ts version was updated in 0.9.4

thepassle avatar May 07 '24 13:05 thepassle