custom-elements-manifest icon indicating copy to clipboard operation
custom-elements-manifest copied to clipboard

Do not output `type` property for CSS properties doc blocks

Open peschee opened this issue 4 years ago • 6 comments

This

import { LitElement } from 'lit-element';

/**
 * @cssprop {color} [--var-test=red] Test css custom prop
 */
export class MyElement extends LitElement {}

would output

{
  "cssProperties": [
    {
      "type": {
        "text": "color"
      },
      "description": "Test css custom prop",
      "name": "--var-test",
      "default": "red"
    }
  ]
}

While the CssCustomProperty has no type in the schema: https://github.com/webcomponents/custom-elements-manifest/blob/a07ec8fd1aa921532bba0e8af21ee993f3bda2a5/schema.d.ts#L322-L354

peschee avatar Nov 07 '21 15:11 peschee

✔️ Deploy Preview for custom-elements-manifest-analyzer ready!

🔨 Explore the source changes: d3c9258d168acc26152f7d62ef4418f57660b84c

🔍 Inspect the deploy log: https://app.netlify.com/sites/custom-elements-manifest-analyzer/deploys/6187eb532f0b5d00074060d6

😎 Browse the preview: https://deploy-preview-148--custom-elements-manifest-analyzer.netlify.app

netlify[bot] avatar Nov 07 '21 15:11 netlify[bot]

My plugin relies on this type being set in the manifest

break-stuff avatar Dec 05 '22 13:12 break-stuff

@break-stuff It is not defined in the schema though. However, is maybe the syntax something you could work with?

https://github.com/webcomponents/custom-elements-manifest/blob/main/schema.d.ts#L394

peschee avatar Dec 05 '22 14:12 peschee

I think that should work for me.

break-stuff avatar Dec 06 '22 12:12 break-stuff