custom-elements-manifest icon indicating copy to clipboard operation
custom-elements-manifest copied to clipboard
verified publisher icon open-wc

feat: third parties

Open thepassle opened this issue 4 years ago • 9 comments

Todo

  • [x] find dependencies list
  • [x] package.json magic (exports map)
  • [x] merge found CEMs
  • [ ] remove third-party modules
  • [ ] figure out user-friendly logging for the findDependencies bit

closes https://github.com/open-wc/custom-elements-manifest/issues/121 closes https://github.com/open-wc/custom-elements-manifest/issues/130 closes https://github.com/open-wc/custom-elements-manifest/issues/123

thepassle avatar Oct 21 '21 11:10 thepassle

✔️ Deploy Preview for custom-elements-manifest-analyzer ready!

🔨 Explore the source changes: 9210ee298f17709858136ac99618bafb8144a59d

🔍 Inspect the deploy log: https://app.netlify.com/sites/custom-elements-manifest-analyzer/deploys/61a693528eb9a80007a8fd1f

😎 Browse the preview: https://deploy-preview-142--custom-elements-manifest-analyzer.netlify.app

netlify[bot] avatar Oct 21 '21 11:10 netlify[bot]

Hey @thepassle how is this PR coming? Would love to see the --packagejson option land, so if there's anything I can do to help with that, please let me know!

Westbrook avatar Nov 30 '21 15:11 Westbrook

Still intend on finishing this, but havent had much time recently to work on it.

thepassle avatar Nov 30 '21 15:11 thepassle

Would you be happy/indifferent/annoyed if I reached in for the package.json change and submitted a stand alone PR?

Westbrook avatar Nov 30 '21 20:11 Westbrook

The easiest would probably be to finish this PR then, its really not far off. Just need to filter out third party modules at the end and test that everything works as expected

thepassle avatar Nov 30 '21 20:11 thepassle

I can dive in and see if I fully understand what that means and get back to you. Would you have minute to catch this branch up to master today or tomorrow to make that easier?

Westbrook avatar Nov 30 '21 20:11 Westbrook

Done

So currently we pick up third party CEMs and we add a isDependency property to them so that we can remove them at the end. That still needs to be done.

And otherwise we just need to make sure all the functionality works as expected (e.g. if i extend a class from a third party, is the inheritance output correctly in the CEM? Etc)

I think thats it

thepassle avatar Nov 30 '21 21:11 thepassle

Does that mean that these to dos are already done?

  • merge found CEMs
  • figure out user-friendly logging for the findDependencies bit

I'll start digging in tomorrow!

Westbrook avatar Nov 30 '21 21:11 Westbrook

Merge found cems is done, logging could be made a bit nicer actually still

thepassle avatar Nov 30 '21 22:11 thepassle

this was done in https://github.com/open-wc/custom-elements-manifest/pull/173

thepassle avatar Jan 11 '23 07:01 thepassle