api-viewer-element icon indicating copy to clipboard operation
api-viewer-element copied to clipboard

fix: respect filtered elements when determining selected

Open bashmish opened this issue 2 years ago • 1 comments

Turned out there was a bug and filtered elements were not respected in getElementData, resulting in a first element in the original manifest to take priority over the first in the filtered array.

This PR should fix that.

PS: I tested this behavior in #153, but maybe not correctly prepared the build and tested partially old code. I thought yarn fixtures, yarn build and then yarn start was a way to go, also tried to keep yarn dev and yarn start running side by side, but smth went wrong apparently resulting in this bug unnoticed. Maybe it's good to document in Contribution Guidelines how to properly work in a dev mode and always serve new version of the lib in the Rocket site.

bashmish avatar Apr 07 '22 16:04 bashmish

Deploy Preview for api-viewer ready!

Name Link
Latest commit 994b9236492c8c28ec9e653431d8ee3b3c9e8ea1
Latest deploy log https://app.netlify.com/sites/api-viewer/deploys/637d1008658af10009946b11
Deploy Preview https://deploy-preview-155--api-viewer.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Apr 07 '22 16:04 netlify[bot]

@web-padawan no worries, I had a small workaround on my side. Thanks for taking this in now 👍

bashmish avatar Nov 23 '22 09:11 bashmish