semantic-conventions
semantic-conventions copied to clipboard
Adjust `process.command*` to be opt-in
Fixes https://github.com/open-telemetry/semantic-conventions/issues/626
Changes
I made it match the container resource.
Merge requirement checklist
- [x] CONTRIBUTING.md guidelines followed.
- [x] Change log entry added, according to the guidelines in When to add a changelog entry.
- If your PR does not need a change log, start the PR title with
[chore]
- If your PR does not need a change log, start the PR title with
- [ ] schema-next.yaml updated with changes to existing conventions.
@inssein we do have a new way of creating a changelog. Please update your PR
Should we also add notes to the properties about sensitive content as well as we do for URL for example? https://github.com/open-telemetry/semantic-conventions/blob/main/model/registry/url.yaml#L63
I'd just want to hear from @breedx-nr and his comment on https://github.com/open-telemetry/semantic-conventions/issues/626#issuecomment-1972085449 before we merge this.
I took the liberty to fix the CI issues. Had to generate the markdown tables and add a change log. I think this is a breaking change.
CC @open-telemetry/semconv-system-approvers
Ah I totally missed the earlier notification, thank you @joaopgrassi for doing that.
Note that this makes the conventions stricter and does not relax anything. Before, if you set one of the process.command* attributes, you didn't need to also set a process.executable* attribute. Now you do. My understanding of these "at least one of" groups is that if you set one of them then all the others are non-required (although it's undefined whether they are then opt-in or recommended).
So I'm not sure that the change does what you want it to do. process.command* was more or less opt-in already.
EDIT: Technically you could just change the requirement description from "conditionally_required: See alternative attributes below." to something like "conditionally_required: This should only be set as opt-in and another alternative (see below) should be preferred"
This PR was marked stale due to lack of activity. It will be closed in 7 days.
This PR was marked stale due to lack of activity. It will be closed in 7 days.
Closed as inactive. Feel free to reopen if this PR is still being worked on.
@inssein please reopen PR again if you still want to implement this feature
@inssein Would you be interested in reopening this PR? The PR was closed by the github-actions bot as being inactive, this PR is very helpful as would solve https://github.com/open-telemetry/semantic-conventions/issues/626
This would require to be rebased on top of the recent project reorg. @inssein would you like to revive this PR?
This PR was marked stale due to lack of activity. It will be closed in 7 days.
Closed as inactive. Feel free to reopen if this PR is still being worked on.