semantic-conventions icon indicating copy to clipboard operation
semantic-conventions copied to clipboard

Adjust `process.command*` to be opt-in

Open inssein opened this issue 1 year ago • 13 comments

Fixes https://github.com/open-telemetry/semantic-conventions/issues/626

Changes

I made it match the container resource.

Merge requirement checklist

inssein avatar Mar 02 '24 20:03 inssein

@inssein we do have a new way of creating a changelog. Please update your PR

trisch-me avatar Mar 05 '24 12:03 trisch-me

Should we also add notes to the properties about sensitive content as well as we do for URL for example? https://github.com/open-telemetry/semantic-conventions/blob/main/model/registry/url.yaml#L63

trisch-me avatar Mar 05 '24 12:03 trisch-me

I'd just want to hear from @breedx-nr and his comment on https://github.com/open-telemetry/semantic-conventions/issues/626#issuecomment-1972085449 before we merge this.

joaopgrassi avatar Mar 06 '24 10:03 joaopgrassi

I took the liberty to fix the CI issues. Had to generate the markdown tables and add a change log. I think this is a breaking change.

CC @open-telemetry/semconv-system-approvers

joaopgrassi avatar Mar 20 '24 13:03 joaopgrassi

Ah I totally missed the earlier notification, thank you @joaopgrassi for doing that.

inssein avatar Mar 20 '24 18:03 inssein

Note that this makes the conventions stricter and does not relax anything. Before, if you set one of the process.command* attributes, you didn't need to also set a process.executable* attribute. Now you do. My understanding of these "at least one of" groups is that if you set one of them then all the others are non-required (although it's undefined whether they are then opt-in or recommended).

So I'm not sure that the change does what you want it to do. process.command* was more or less opt-in already.

EDIT: Technically you could just change the requirement description from "conditionally_required: See alternative attributes below." to something like "conditionally_required: This should only be set as opt-in and another alternative (see below) should be preferred"

Oberon00 avatar Mar 21 '24 06:03 Oberon00

This PR was marked stale due to lack of activity. It will be closed in 7 days.

github-actions[bot] avatar Apr 06 '24 03:04 github-actions[bot]

This PR was marked stale due to lack of activity. It will be closed in 7 days.

github-actions[bot] avatar Apr 22 '24 03:04 github-actions[bot]

Closed as inactive. Feel free to reopen if this PR is still being worked on.

github-actions[bot] avatar Apr 30 '24 03:04 github-actions[bot]

@inssein please reopen PR again if you still want to implement this feature

trisch-me avatar Apr 30 '24 08:04 trisch-me

@inssein Would you be interested in reopening this PR? The PR was closed by the github-actions bot as being inactive, this PR is very helpful as would solve https://github.com/open-telemetry/semantic-conventions/issues/626

rogercoll avatar Aug 20 '24 09:08 rogercoll

This would require to be rebased on top of the recent project reorg. @inssein would you like to revive this PR?

ChrsMark avatar Sep 19 '24 14:09 ChrsMark

This PR was marked stale due to lack of activity. It will be closed in 7 days.

github-actions[bot] avatar Oct 05 '24 03:10 github-actions[bot]

Closed as inactive. Feel free to reopen if this PR is still being worked on.

github-actions[bot] avatar Oct 13 '24 03:10 github-actions[bot]