semantic-conventions
semantic-conventions copied to clipboard
open-telemetry
[cloud provider] Add AWS EC2 instance id semantic convention
Changes
Add semantic convention for AWS EC2 instance id. This is similar to #15, and is inspired by #576, to ensure that the EC2 instance id can be correctly identified despite ambiguity in the host.id convention meaning.
Note: if the PR is touching an area that is not listed in the existing areas, or the area does not have sufficient domain experts coverage, the PR might be tagged as experts needed and move slowly until experts are identified.
Merge requirement checklist
- [ ] CONTRIBUTING.md guidelines followed.
- [ ] CHANGELOG.md updated for non-trivial changes.
- [ ] schema-next.yaml updated with changes to existing conventions.
This PR was marked stale due to lack of activity. It will be closed in 7 days.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Closed as inactive. Feel free to reopen if this PR is still being worked on.
Hi @mx-psi !
We changed how the CHANGELOG.md is managed. Please take a look at https://github.com/open-telemetry/semantic-conventions/blob/main/CONTRIBUTING.md#adding-a-changelog-entry to see what needs to be done. Sorry for the disruption.
Thanks @joaopgrassi, addressed. It looks like there is some sort of issue with the changelog check though that is (AFAICT) unrelated to this PR:
Error: flag needs an argument: --version
This PR was marked stale due to lack of activity. It will be closed in 7 days.
This PR was marked stale due to lack of activity. It will be closed in 7 days.
Closed as inactive. Feel free to reopen if this PR is still being worked on.
This PR was marked stale due to lack of activity. It will be closed in 7 days.
@mx-psi could you please update this PR to have all attributes defined in the registry and autogenerated and use only refs outside of the registry?
I'd like to get a wider discussion on different attributes we have for host.id, service.instance.id, aws.ec2.instance.id and any others. It seems to be in the scope of Resources and Entities WG.
I think we should either wait for the Resource project to start and get consensus in that WG or at least discuss it in the SemConv SIG meeting.
I'd like to get a wider discussion on different attributes we have for
host.id,service.instance.id,aws.ec2.instance.idand any others. It seems to be in the scope of Resources and Entities WG.I think we should either wait for the Resource project to start and get consensus in that WG or at least discuss it in the SemConv SIG meeting.
Should we close this PR then for now? Not sure what the implications are for this PR
Should we close this PR then for now? Not sure what the implications are for this PR
Please don't close it :)
I'm suggesting to join Semantic Conventions meeting on Mon 8am to discuss how we should treat all the instance ids. Or an entities meeting on every other Thu 8am (happening right now).
The meetings details are available in https://github.com/open-telemetry/community
It's usually hard for me to join this meeting, but I may be able to join on Monday.
Based on https://github.com/open-telemetry/semantic-conventions/pull/576#issuecomment-2115510275, I am going to hold off from further making changes on this PR until the Entities SIG gets up to speed
This PR was marked stale due to lack of activity. It will be closed in 7 days.
Given the status of Entities WG and updates to semconv, this PR can now make progress and be submitted.
It has the following:
- A well defined resource "name" / type that also is the "namespace" for attributes.
- A well defined notion of "identity" i.e. identifying attributes.
Thanks and sorry for the long delay!
Given the status of Entities WG and updates to semconv, this PR can now make progress and be submitted.
It has the following:
- A well defined resource "name" / type that also is the "namespace" for attributes.
- A well defined notion of "identity" i.e. identifying attributes.
Thanks and sorry for the long delay!
Thank you for the update! I will update this PR then (but it may take me some time to get back to it)